You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/09/14 03:55:13 UTC

[GitHub] [pulsar] mostafij-rahman opened a new pull request #12029: Issue 12019 Fix flaky test ManagedLedgerTest.testMaximumRolloverTime

mostafij-rahman opened a new pull request #12029:
URL: https://github.com/apache/pulsar/pull/12029


   Fixes #12019
   
   
   ### Motivation
   
   Fix flaky test ManagedLedgerTest.testMaximumRolloverTime
   
   This test was failing sporadically due to using Thread.sleep(2000). However, due to using a constant time of 2000 milliseconds, it sometimes added more entry than expected.  
   
   ### Modifications
   
   - Remove Thread.sleep(2000)
   - Put the assertion into Awaitility.await()
   
   ### Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ### Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API: (no)
     - The schema: (no)
     - The default values of configurations: (no)
     - The wire protocol: (no)
     - The rest endpoints: (no)
     - The admin cli options: (no)
     - Anything that affects deployment: (no)
   
   ### Documentation
   
   Check the box below and label this PR (if you have committer privilege).
   
   Need to update docs? 
     
   - [x] no-need-doc 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] mostafij-rahman closed pull request #12029: Issue 12019 Fix flaky test ManagedLedgerTest.testMaximumRolloverTime

Posted by GitBox <gi...@apache.org>.

mostafij-rahman closed pull request #12029:
URL: https://github.com/apache/pulsar/pull/12029


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org