[GitHub] [tvm-rfcs] areusch commented on a change in pull request #9: [RFC] TVM Unified Static Memory Planning

[GitBox <gi...@apache.org>]

areusch commented on a change in pull request #9:
URL: https://github.com/apache/tvm-rfcs/pull/9#discussion_r720860165



##########
File path: rfcs/0009_Unified_Static_Memory_Planning.md
##########
@@ -0,0 +1,473 @@
+    Feature Name: Unified Static Memory Planner
+    Start Date: 2021 June 1
+    RFC PR: #0009
+    GitHub Issue: https://github.com/apache/tvm/issues/8404
+
+# Background
+
+Currently, given a ML model primarily TVM will generate two main artifacts :
+
+* A1 : Description of the sequential execution of operators :
+  1. If the "executor" is "graph", this would be a JSON

Review comment:
       sorry i mean that by `"executor"` here, you mean the value of the `"executor"` key in MLF `metadata.json`. However, that's a micro-specific (for now) artifact. To make the RFC easier to follow, suggest either including a pointer so that a reader could determine this, or just saying something less specific like "If building for the graph executor."




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org