You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Martin Grigorov (JIRA)" <ji...@apache.org> on 2013/02/26 15:00:13 UTC

[jira] [Created] (WICKET-5057) FilteringHeaderResponse requires a usage of FilteringHeaderResponse.IHeaderResponseFilter for no reason when FilteredHeaderItem is used

Martin Grigorov created WICKET-5057:
---------------------------------------

             Summary: FilteringHeaderResponse requires a usage of FilteringHeaderResponse.IHeaderResponseFilter for no reason when FilteredHeaderItem is used
                 Key: WICKET-5057
                 URL: https://issues.apache.org/jira/browse/WICKET-5057
             Project: Wicket
          Issue Type: Improvement
          Components: wicket
    Affects Versions: 6.6.0
            Reporter: Martin Grigorov


org.apache.wicket.markup.head.filter.FilteringHeaderResponse#render(HeaderItem) doesn't need a filter when a FilteredHeaderItem is processed. But later org.apache.wicket.markup.head.filter.FilteringHeaderResponse#render(HeaderItem item, String filterName) requires such filter.

I think we can create a bundle (List<HeaderItem>) on the fly in this case for the first FHI.

Otherwise right now the developer has to use:

AbstractHeaderResponseFilter dummyFilter = new AbstractHeaderResponseFilter(coreFilterName) {
            @Override
            protected boolean acceptsWrapped(HeaderItem item) {
                return false;
            }
        };
filters.add(dummyFilter);

in his HeaderResponseDecorator.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira