[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #2948: Remove CI Caching to preserve diskspace

[GitBox <gi...@apache.org>]

alamb commented on code in PR #2948:
URL: https://github.com/apache/arrow-datafusion/pull/2948#discussion_r925984942


##########
.github/workflows/rust.yml:
##########
@@ -46,36 +46,29 @@ jobs:
           # and thus do not depend on the OS, arch nor rust version.
           path: /github/home/.cargo
           key: cargo-cache-
-      - name: Cache Rust dependencies

Review Comment:
   ```
   This cache is automatically keyed by:
   
   the github [job_id](https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_id),
   the rustc release / host / hash,
   the value of some compiler-specific environment variables (eg. RUSTFLAGS, etc), and
   a hash of all Cargo.lock / Cargo.toml files found anywhere in the repository (if present).
   a hash of all rust-toolchain / rust-toolchain.toml files in the root of the repository (if present).
   ```
   
   Seems particularly relevant to why the basic cache wasn't working for us



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org