You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2021/07/02 17:02:06 UTC
[GitHub] [commons-imaging] dependabot[bot] opened a new pull request #156: Bump spotbugs from 4.2.3 to 4.3.0
dependabot[bot] opened a new pull request #156:
URL: https://github.com/apache/commons-imaging/pull/156
Bumps [spotbugs](https://github.com/spotbugs/spotbugs) from 4.2.3 to 4.3.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/spotbugs/spotbugs/releases">spotbugs's releases</a>.</em></p>
<blockquote>
<h2>SpotBugs 4.3.0</h2>
<h3>CHANGELOG</h3>
<ul>
<li><a href="https://github.com/spotbugs/spotbugs/blob/4.3.0/CHANGELOG.md">https://github.com/spotbugs/spotbugs/blob/4.3.0/CHANGELOG.md</a></li>
</ul>
<h3>CHECKSUM</h3>
<table>
<thead>
<tr>
<th>file</th>
<th>checksum (sha256)</th>
</tr>
</thead>
<tbody>
<tr>
<td>spotbugs-4.3.0-javadoc.jar</td>
<td>58eeba2dcdcfd6f73c5203a5745ab1a120ded4df484a6d70124a1dcc0573b37f</td>
</tr>
<tr>
<td>spotbugs-4.3.0-sources.jar</td>
<td>ab8847620bd47be9f20cad53462bce1ae49e5495a75796f9ba8d547a703f346e</td>
</tr>
<tr>
<td>spotbugs-4.3.0.tgz</td>
<td>bf9687476cebe0876d9a27679af97705a79b3f0f5629519ca6ec086741b6d884</td>
</tr>
<tr>
<td>spotbugs-4.3.0.zip</td>
<td>a1c59df789b14a423f24127501db1bd6b0ae642f079f7212ff61343cd387d7f0</td>
</tr>
<tr>
<td>spotbugs-annotations-4.3.0-javadoc.jar</td>
<td>a49426fbd559394d176c7bc81c8b601b496768048ce29e6f36e05dfcc42f6c19</td>
</tr>
<tr>
<td>spotbugs-annotations-4.3.0-sources.jar</td>
<td>b338136e3e82d585348cde58a8fe3a678e16f51a35c31c1463e05fefef557aad</td>
</tr>
<tr>
<td>spotbugs-annotations.jar</td>
<td>ae576422c3a090adc372a4542214a38e195f62ada906184e773a8916d83ec386</td>
</tr>
<tr>
<td>spotbugs-ant-4.3.0-javadoc.jar</td>
<td>150875811f177a99c60e8e7afdc5c5d3e58393f84de2662bc32d0409254688a0</td>
</tr>
<tr>
<td>spotbugs-ant-4.3.0-sources.jar</td>
<td>c74dec42c0ed0dd1ae02a7410d8e0f0dbbee23e8e7da4a21910863677fcdbc8e</td>
</tr>
<tr>
<td>spotbugs-ant.jar</td>
<td>9233e48d37882ae4e7a42e9f42ef4c63d6f802cf8f3b03ba575bee26e5032367</td>
</tr>
<tr>
<td>spotbugs.jar</td>
<td>c619ef5233ff1115e5b4ceeacd4bed4070a7e5bd95d9c3172b7376cd0cbb1c72</td>
</tr>
<tr>
<td>test-harness-4.3.0-javadoc.jar</td>
<td>463ab8a236314d537f3ff78d229ed5a11a56143db18f1e1c87b64c8d93d1eac4</td>
</tr>
<tr>
<td>test-harness-4.3.0-sources.jar</td>
<td>2c1f5ef929453f3b682c7eb7c1e22db3082b5f74c5a5be439be5dc31dd7a31aa</td>
</tr>
<tr>
<td>test-harness-4.3.0.jar</td>
<td>55d3a590b81ffec48293a76c45c0695914b405bf9f02bfb930e3ab99b5867d4f</td>
</tr>
<tr>
<td>test-harness-core-4.3.0-javadoc.jar</td>
<td>b817f0ca2af5fd603ffdf4d95e5071961a2cb2552bbb9403cf1f5390ca0a37c9</td>
</tr>
<tr>
<td>test-harness-core-4.3.0-sources.jar</td>
<td>f320f5eb4069e9686b760b2a6a0760989753225f9e9ce1226e3258ec64795d8a</td>
</tr>
<tr>
<td>test-harness-core-4.3.0.jar</td>
<td>cbec03867e077079d011e85f9932fb230fae3d909f741cffaa4c8097e91fdf40</td>
</tr>
<tr>
<td>test-harness-jupiter-4.3.0-javadoc.jar</td>
<td>4edbdf0a8293458c1356c0bec95ee7c4e4307e62641127593f8443ba8ddee63b</td>
</tr>
<tr>
<td>test-harness-jupiter-4.3.0-sources.jar</td>
<td>210353a57016e26b1a654d936a15f039613fa1ac532d485c1b1d03902f6c6315</td>
</tr>
<tr>
<td>test-harness-jupiter-4.3.0.jar</td>
<td>17e8d78d1868f86e63f3e5e3d878e86f3d7fb1b8cf1a8d5f893333c982bfd3e2</td>
</tr>
</tbody>
</table>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/spotbugs/spotbugs/blob/master/CHANGELOG.md">spotbugs's changelog</a>.</em></p>
<blockquote>
<h2>4.3.0 - 2021-07-01</h2>
<h3>Fixed</h3>
<ul>
<li><code>MS_EXPOSE_REP</code> and <code>EI_EXPOSE_REP</code> are now reported for code returning a reference to a mutable object indirectly (e.g. via a local variable)</li>
</ul>
<h3>Changed</h3>
<ul>
<li>Bump ObjectWeb ASM from 9.1 to 9.2 supporting JDK 18 (<a href="https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1591">#1591</a>)</li>
<li>Bump Saxon-HE from 10.3 to 10.5 (<a href="https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1513">#1513</a>)</li>
<li>Bump gson from 2.8.6 to 2.8.7 (<a href="https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1556">#1556</a>)</li>
<li>Function <code>mutableSignature()</code> improved and factored out from the <code>MutableStaticFields</code> detector</li>
</ul>
<h3>Added</h3>
<ul>
<li>New bugs <code>MS_EXPOSE_BUF</code>, <code>EI_EXPOSE_BUF</code>, <code>EI_EXPOSE_STATIC_BUF2</code> and <code>EI_EXPOSE_BUF2</code> by the <code>FindReturnRef</code> detector to detect cases where buffers or their backing arrays are exposed (see <a href="https://wiki.sei.cmu.edu/confluence/display/java/FIO05-J.+Do+not+expose+buffers+or+their+backing+arrays+methods+to+untrusted+code">SEI CERT rule FIO05-J</a>)</li>
<li><code>MS_EXPOSE_REP</code>, <code>EI_EXPOSE_REP</code>, <code>EI_EXPOSE_STATIC_REP2</code> and <code>EI_EXPOSE_REP2</code> now report for shallowly copied arrays (using clone()) of mutable objects</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/spotbugs/spotbugs/commit/0dfbd8166ebe6c9e66614650d65d06f29fa46e96"><code>0dfbd81</code></a> chore: release v4.3.0</li>
<li><a href="https://github.com/spotbugs/spotbugs/commit/4d1087891315881cab18c69fc870bc226a0d65e2"><code>4d10878</code></a> docs: add a missing CHANGELOG entry for <a href="https://github-redirect.dependabot.com/spotbugs/spotbugs/issues/1591">#1591</a></li>
<li><a href="https://github.com/spotbugs/spotbugs/commit/5f3237262fb3d13909a9f48613b15332852347b1"><code>5f32372</code></a> build(deps): bump asmVersion from 9.1 to 9.2</li>
<li><a href="https://github.com/spotbugs/spotbugs/commit/e8e054ae665405a1597d48ead58c4ba62b6131fb"><code>e8e054a</code></a> Mutable array clones (<a href="https://github-redirect.dependabot.com/spotbugs/spotbugs/issues/1582">#1582</a>)</li>
<li><a href="https://github.com/spotbugs/spotbugs/commit/67835f547bea66e49515f4caf244b8e7639f5348"><code>67835f5</code></a> build(deps): bump mockito-core from 3.11.1 to 3.11.2</li>
<li><a href="https://github.com/spotbugs/spotbugs/commit/4ecab4b47c67d0d26fc250c6a9bbe920e45bfadd"><code>4ecab4b</code></a> build(deps): bump com.diffplug.spotless from 5.13.0 to 5.14.0</li>
<li><a href="https://github.com/spotbugs/spotbugs/commit/daba7a1db1e146dd9cc5a3c4d1b84da1e9976125"><code>daba7a1</code></a> build(deps): bump checker-qual from 3.14.0 to 3.15.0</li>
<li><a href="https://github.com/spotbugs/spotbugs/commit/e2daa309052eb4230055b3947ec9212898a60f54"><code>e2daa30</code></a> Constants changed to SCREAMING_SNAKE_CASE and a typo fixed in the error messa...</li>
<li><a href="https://github.com/spotbugs/spotbugs/commit/9467880345debdbaca21a452023cdadb3e94359a"><code>9467880</code></a> Pattern matching optimized; typos and grammar errors fixed in the descriptions</li>
<li><a href="https://github.com/spotbugs/spotbugs/commit/abc2ae2ebd02e9deba3b78a8f799675304f07703"><code>abc2ae2</code></a> Extend FindReturnRef to warn for exposing buffers</li>
<li>Additional commits viewable in <a href="https://github.com/spotbugs/spotbugs/compare/4.2.3...4.3.0">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-imaging] kinow closed pull request #156: Bump spotbugs from 4.2.3 to 4.3.0
Posted by GitBox <gi...@apache.org>.
kinow closed pull request #156:
URL: https://github.com/apache/commons-imaging/pull/156
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-imaging] kinow commented on pull request #156: Bump spotbugs from 4.2.3 to 4.3.0
Posted by GitBox <gi...@apache.org>.
kinow commented on pull request #156:
URL: https://github.com/apache/commons-imaging/pull/156#issuecomment-873261776
Ah, some new errors found by CI. Will have to fix those when merging.
```
Error: Medium: new org.apache.commons.imaging.ImageInfo(String, int, List, ImageFormat, String, int, String, int, int, float, int, float, int, boolean, boolean, boolean, ImageInfo$ColorType, ImageInfo$CompressionAlgorithm) may expose internal representation by storing an externally mutable object into ImageInfo.comments [org.apache.commons.imaging.ImageInfo] At ImageInfo.java:[line 117] EI_EXPOSE_REP2
Error: Medium: new org.apache.commons.imaging.common.BinaryOutputStream(OutputStream) may expose internal representation by storing an externally mutable object into BinaryOutputStream.os [org.apache.commons.imaging.common.BinaryOutputStream] At BinaryOutputStream.java:[line 35] EI_EXPOSE_REP2
Error: Medium: new org.apache.commons.imaging.common.BinaryOutputStream(OutputStream, ByteOrder) may expose internal representation by storing an externally mutable object into BinaryOutputStream.os [org.apache.commons.imaging.common.BinaryOutputStream] At BinaryOutputStream.java:[line 31] EI_EXPOSE_REP2
Error: Medium: new org.apache.commons.imaging.common.mylzw.BitsToByteInputStream(MyBitInputStream, int) may expose internal representation by storing an externally mutable object into BitsToByteInputStream.is [org.apache.commons.imaging.common.mylzw.BitsToByteInputStream] At BitsToByteInputStream.java:[line 27] EI_EXPOSE_REP2
Error: Medium: new org.apache.commons.imaging.common.mylzw.MyBitOutputStream(OutputStream, ByteOrder) may expose internal representation by storing an externally mutable object into MyBitOutputStream.os [org.apache.commons.imaging.common.mylzw.MyBitOutputStream] At MyBitOutputStream.java:[line 32] EI_EXPOSE_REP2
Error: Medium: new org.apache.commons.imaging.common.mylzw.MyLzwCompressor(int, ByteOrder, boolean, MyLzwCompressor$Listener) may expose internal representation by storing an externally mutable object into MyLzwCompressor.listener [org.apache.commons.imaging.common.mylzw.MyLzwCompressor] At MyLzwCompressor.java:[line 44] EI_EXPOSE_REP2
Error: Medium: org.apache.commons.imaging.formats.gif.GifImageMetadata.getItems() may expose internal representation by returning GifImageMetadata.items [org.apache.commons.imaging.formats.gif.GifImageMetadata] At GifImageMetadata.java:[line 63] EI_EXPOSE_REP
Error: Medium: org.apache.commons.imaging.formats.jpeg.JpegImageMetadata.getExif() may expose internal representation by returning JpegImageMetadata.exif [org.apache.commons.imaging.formats.jpeg.JpegImageMetadata] At JpegImageMetadata.java:[line 51] EI_EXPOSE_REP
Error: Medium: org.apache.commons.imaging.formats.jpeg.JpegImageMetadata.getPhotoshop() may expose internal representation by returning JpegImageMetadata.photoshop [org.apache.commons.imaging.formats.jpeg.JpegImageMetadata] At JpegImageMetadata.java:[line 55] EI_EXPOSE_REP
Error: Medium: new org.apache.commons.imaging.formats.jpeg.JpegImageMetadata(JpegPhotoshopMetadata, TiffImageMetadata) may expose internal representation by storing an externally mutable object into JpegImageMetadata.exif [org.apache.commons.imaging.formats.jpeg.JpegImageMetadata] At JpegImageMetadata.java:[line 47] EI_EXPOSE_REP2
Error: Medium: new org.apache.commons.imaging.formats.jpeg.JpegImageMetadata(JpegPhotoshopMetadata, TiffImageMetadata) may expose internal representation by storing an externally mutable object into JpegImageMetadata.photoshop [org.apache.commons.imaging.formats.jpeg.JpegImageMetadata] At JpegImageMetadata.java:[line 46] EI_EXPOSE_REP2
Error: Medium: org.apache.commons.imaging.formats.jpeg.decoder.JpegDecoder.decode(ByteSource) may expose internal representation by returning JpegDecoder.image [org.apache.commons.imaging.formats.jpeg.decoder.JpegDecoder] At JpegDecoder.java:[line 553] EI_EXPOSE_REP
Error: Medium: new org.apache.commons.imaging.formats.jpeg.iptc.PhotoshopApp13Data(List, List) may expose internal representation by storing an externally mutable object into PhotoshopApp13Data.rawBlocks [org.apache.commons.imaging.formats.jpeg.iptc.PhotoshopApp13Data] At PhotoshopApp13Data.java:[line 29] EI_EXPOSE_REP2
Error: Medium: new org.apache.commons.imaging.formats.jpeg.iptc.PhotoshopApp13Data(List, List) may expose internal representation by storing an externally mutable object into PhotoshopApp13Data.records [org.apache.commons.imaging.formats.jpeg.iptc.PhotoshopApp13Data] At PhotoshopApp13Data.java:[line 30] EI_EXPOSE_REP2
Error: Medium: org.apache.commons.imaging.formats.tiff.TiffField.getFieldType() may expose internal representation by returning TiffField.fieldType [org.apache.commons.imaging.formats.tiff.TiffField] At TiffField.java:[line 91] EI_EXPOSE_REP
Error: Medium: new org.apache.commons.imaging.formats.tiff.TiffImageMetadata$Directory(ByteOrder, TiffDirectory) may expose internal representation by storing an externally mutable object into TiffImageMetadata$Directory.directory [org.apache.commons.imaging.formats.tiff.TiffImageMetadata$Directory] At TiffImageMetadata.java:[line 69] EI_EXPOSE_REP2
Error: Medium: org.apache.commons.imaging.formats.tiff.write.TiffOutputDirectory.setNextDirectory(TiffOutputDirectory) may expose internal representation by storing an externally mutable object into TiffOutputDirectory.nextDirectory [org.apache.commons.imaging.formats.tiff.write.TiffOutputDirectory] At TiffOutputDirectory.java:[line 82] EI_EXPOSE_REP2
Error: Medium: new org.apache.commons.imaging.palette.QuantizedPalette(List, int) may expose internal representation by storing an externally mutable object into QuantizedPalette.subsets [org.apache.commons.imaging.palette.QuantizedPalette] At QuantizedPalette.java:[line 29] EI_EXPOSE_REP2
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-imaging] dependabot[bot] commented on pull request #156: Bump spotbugs from 4.2.3 to 4.3.0
Posted by GitBox <gi...@apache.org>.
dependabot[bot] commented on pull request #156:
URL: https://github.com/apache/commons-imaging/pull/156#issuecomment-879874226
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file.
If you change your mind, just re-open this PR and I'll resolve any conflicts on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-imaging] kinow edited a comment on pull request #156: Bump spotbugs from 4.2.3 to 4.3.0
Posted by GitBox <gi...@apache.org>.
kinow edited a comment on pull request #156:
URL: https://github.com/apache/commons-imaging/pull/156#issuecomment-873261776
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org