You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by "zrhoffman (via GitHub)" <gi...@apache.org> on 2023/02/15 16:06:31 UTC
[GitHub] [trafficcontrol-trafficops-types] zrhoffman opened a new pull request, #2: Add `ttlOverride` to `RequestCDN`
zrhoffman opened a new pull request, #2:
URL: https://github.com/apache/trafficcontrol-trafficops-types/pull/2
This PR adds the `ttlOverride` field to the `RequestCDN` interface.
This PR also makes `ResponseCDN` extend `RequestCDN` instead of redeclaring fields.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol-trafficops-types] zrhoffman commented on a diff in pull request #2: Add `ttlOverride` to `RequestCDN`
Posted by "zrhoffman (via GitHub)" <gi...@apache.org>.
zrhoffman commented on code in PR #2:
URL: https://github.com/apache/trafficcontrol-trafficops-types/pull/2#discussion_r1108711901
##########
src/cdn.ts:
##########
@@ -26,17 +26,19 @@ export interface RequestCDN {
domainName: string;
/** The name of the CDN. */
name: string;
+ /**
+ * A TTL (Time To Live) value, in seconds, that, if set, overrides all set
+ * TTL values on Delivery Services in this CDN.
+ */
+ ttlOverride?: number | null;
Review Comment:
Thanks, made `ttlOverride` nullable in 5b502ead92.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol-trafficops-types] zrhoffman commented on a diff in pull request #2: Add `ttlOverride` to `RequestCDN`
Posted by "zrhoffman (via GitHub)" <gi...@apache.org>.
zrhoffman commented on code in PR #2:
URL: https://github.com/apache/trafficcontrol-trafficops-types/pull/2#discussion_r1108817144
##########
src/cdn.ts:
##########
@@ -26,17 +26,19 @@ export interface RequestCDN {
domainName: string;
/** The name of the CDN. */
name: string;
+ /**
+ * A TTL (Time To Live) value, in seconds, that, if set, overrides all set
+ * TTL values on Delivery Services in this CDN.
+ */
+ ttlOverride?: number;
Review Comment:
* Reverted making `ResponseCDN` extend `RequestCDN` in da46bce8f9
* Make ttlOverride nullable in requests but optional in responses in f778ad65b1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol-trafficops-types] zrhoffman commented on a diff in pull request #2: Add `ttlOverride` to `RequestCDN`
Posted by "zrhoffman (via GitHub)" <gi...@apache.org>.
zrhoffman commented on code in PR #2:
URL: https://github.com/apache/trafficcontrol-trafficops-types/pull/2#discussion_r1108811469
##########
src/cdn.ts:
##########
@@ -26,17 +26,19 @@ export interface RequestCDN {
domainName: string;
/** The name of the CDN. */
name: string;
+ /**
+ * A TTL (Time To Live) value, in seconds, that, if set, overrides all set
+ * TTL values on Delivery Services in this CDN.
+ */
+ ttlOverride?: number;
Review Comment:
gotcha
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol-trafficops-types] ocket8888 commented on a diff in pull request #2: Add `ttlOverride` to `RequestCDN`
Posted by "ocket8888 (via GitHub)" <gi...@apache.org>.
ocket8888 commented on code in PR #2:
URL: https://github.com/apache/trafficcontrol-trafficops-types/pull/2#discussion_r1108807748
##########
src/cdn.ts:
##########
@@ -26,17 +26,19 @@ export interface RequestCDN {
domainName: string;
/** The name of the CDN. */
name: string;
+ /**
+ * A TTL (Time To Live) value, in seconds, that, if set, overrides all set
+ * TTL values on Delivery Services in this CDN.
+ */
+ ttlOverride?: number;
Review Comment:
... but it _is_ allowed to be `null` in requests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol-trafficops-types] ocket8888 merged pull request #2: Add `ttlOverride` to `RequestCDN`
Posted by "ocket8888 (via GitHub)" <gi...@apache.org>.
ocket8888 merged PR #2:
URL: https://github.com/apache/trafficcontrol-trafficops-types/pull/2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol-trafficops-types] ocket8888 commented on a diff in pull request #2: Add `ttlOverride` to `RequestCDN`
Posted by "ocket8888 (via GitHub)" <gi...@apache.org>.
ocket8888 commented on code in PR #2:
URL: https://github.com/apache/trafficcontrol-trafficops-types/pull/2#discussion_r1108701418
##########
src/cdn.ts:
##########
@@ -26,17 +26,19 @@ export interface RequestCDN {
domainName: string;
/** The name of the CDN. */
name: string;
+ /**
+ * A TTL (Time To Live) value, in seconds, that, if set, overrides all set
+ * TTL values on Delivery Services in this CDN.
+ */
+ ttlOverride?: number | null;
Review Comment:
I don't believe this is allowed to be `null` in responses; I think the `omitempty` guarantees that any "null" values are coerced to `undefined`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol-trafficops-types] zrhoffman commented on a diff in pull request #2: Add `ttlOverride` to `RequestCDN`
Posted by "zrhoffman (via GitHub)" <gi...@apache.org>.
zrhoffman commented on code in PR #2:
URL: https://github.com/apache/trafficcontrol-trafficops-types/pull/2#discussion_r1108718969
##########
src/cdn.ts:
##########
@@ -26,17 +26,19 @@ export interface RequestCDN {
domainName: string;
/** The name of the CDN. */
name: string;
+ /**
+ * A TTL (Time To Live) value, in seconds, that, if set, overrides all set
+ * TTL values on Delivery Services in this CDN.
+ */
+ ttlOverride?: number | null;
Review Comment:
made it non-nullable, I mean
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org