You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@wicket.apache.org by "Martin Tzvetanov Grigorov (Jira)" <ji...@apache.org> on 2021/06/25 11:52:00 UTC

[jira] [Resolved] (WICKET-6892) CookieUtils save method: incomplete javadoc

     [ https://issues.apache.org/jira/browse/WICKET-6892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Tzvetanov Grigorov resolved WICKET-6892.
-----------------------------------------------
    Resolution: Won't Fix

> CookieUtils save method: incomplete javadoc
> -------------------------------------------
>
>                 Key: WICKET-6892
>                 URL: https://issues.apache.org/jira/browse/WICKET-6892
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket-core
>    Affects Versions: 8.12.0
>            Reporter: Michel Trefcon
>            Priority: Trivial
>              Labels: easyfix, javadoc
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> The java doc of the CookieUtils.save method is 'Create a Cookie with key and value and save it in the browser with the next response' ( [https://github.com/apache/wicket/blob/rel/wicket-8.12.0/wicket-core/src/main/java/org/apache/wicket/util/cookies/CookieUtils.java#L147] ).
> But when we look to the source code, it doesn't only create the cookie, it updates the cookie if it exists.
> it may confuse a developer a little bit.
> The javadoc fix could be  'Create a Cookie with key and value or update the Cookie value if the Cookie exists and save it in the browser with the next response'.
> We could rename the method save into createOrUpdate but this would break the backward compatibility.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)