You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/12/21 09:21:41 UTC
[GitHub] [camel-quarkus] aldettinger opened a new pull request #2088: Added JSONata extension
aldettinger opened a new pull request #2088:
URL: https://github.com/apache/camel-quarkus/pull/2088
[ ] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #.
[ ] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough.
[ ] Phrases like Fix #<issueNumber> or Fixes #<issueNumber> will auto-close the named issue upon merging the pull request. Using them is typically a good idea.
[ ] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request.
[ ] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] oscerd commented on a change in pull request #2088: Added JSONata extension
Posted by GitBox <gi...@apache.org>.
oscerd commented on a change in pull request #2088:
URL: https://github.com/apache/camel-quarkus/pull/2088#discussion_r546621735
##########
File path: pom.xml
##########
@@ -60,7 +60,7 @@
<google-http-client.version>1.34.0</google-http-client.version>
<google-auth-library-oauth2-http.version>0.21.1</google-auth-library-oauth2-http.version> <!-- Mess in google-cloud-bom -->
<guava.version>29.0-jre</guava.version>
- <gson.version>2.8.5</gson.version>
+ <gson.version>2.8.6</gson.version><!-- JSONata -->
Review comment:
2.8.6 doesn't work in OSGi. This is why is not updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #2088: Added JSONata extension
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #2088:
URL: https://github.com/apache/camel-quarkus/pull/2088#discussion_r546631373
##########
File path: pom.xml
##########
@@ -60,7 +60,7 @@
<google-http-client.version>1.34.0</google-http-client.version>
<google-auth-library-oauth2-http.version>0.21.1</google-auth-library-oauth2-http.version> <!-- Mess in google-cloud-bom -->
<guava.version>29.0-jre</guava.version>
- <gson.version>2.8.5</gson.version>
+ <gson.version>2.8.6</gson.version><!-- JSONata -->
Review comment:
Thanks for the info. Is there a Gson issue so that we can track the progress?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #2088: Added JSONata extension
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #2088:
URL: https://github.com/apache/camel-quarkus/pull/2088#discussion_r546619167
##########
File path: integration-tests/jsonata/src/main/resources/spec/expressions.json
##########
@@ -0,0 +1,5 @@
+{
+ "name": FirstName & " " & Surname,
+ "mobile": Phone[type = "mobile"].number
Review comment:
Yes, I think using somethig else than .json would be less misleading for both users and IDEs/editors :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on a change in pull request #2088: Added JSONata extension
Posted by GitBox <gi...@apache.org>.
aldettinger commented on a change in pull request #2088:
URL: https://github.com/apache/camel-quarkus/pull/2088#discussion_r546617410
##########
File path: pom.xml
##########
@@ -60,7 +60,7 @@
<google-http-client.version>1.34.0</google-http-client.version>
<google-auth-library-oauth2-http.version>0.21.1</google-auth-library-oauth2-http.version> <!-- Mess in google-cloud-bom -->
<guava.version>29.0-jre</guava.version>
- <gson.version>2.8.5</gson.version>
+ <gson.version>2.8.6</gson.version><!-- JSONata -->
Review comment:
That could be discussed in [CAMEL-15981](https://issues.apache.org/jira/browse/CAMEL-15981).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #2088: Added JSONata extension
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #2088:
URL: https://github.com/apache/camel-quarkus/pull/2088#discussion_r546605397
##########
File path: pom.xml
##########
@@ -60,7 +60,7 @@
<google-http-client.version>1.34.0</google-http-client.version>
<google-auth-library-oauth2-http.version>0.21.1</google-auth-library-oauth2-http.version> <!-- Mess in google-cloud-bom -->
<guava.version>29.0-jre</guava.version>
- <gson.version>2.8.5</gson.version>
+ <gson.version>2.8.6</gson.version><!-- JSONata -->
Review comment:
This is OK for now, but in the long term, we should aim at inheriting `${gson-version}` from camel-dependencies here. Could you plz. perform the necessary changes in Camel so that all their components dependent on Gson use their `${gson-version}` that should be upgraded to 2.8.6?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on a change in pull request #2088: Added JSONata extension
Posted by GitBox <gi...@apache.org>.
aldettinger commented on a change in pull request #2088:
URL: https://github.com/apache/camel-quarkus/pull/2088#discussion_r546613885
##########
File path: integration-tests/jsonata/src/main/resources/spec/expressions.json
##########
@@ -0,0 +1,5 @@
+{
+ "name": FirstName & " " & Surname,
+ "mobile": Phone[type = "mobile"].number
Review comment:
It's not valid JSON. The best term I could find is "spec" from the camel-jsontata documentation, so I would propose to rename it to expressions.spec then. What do you think ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #2088: Added JSONata extension
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #2088:
URL: https://github.com/apache/camel-quarkus/pull/2088#discussion_r546621392
##########
File path: pom.xml
##########
@@ -60,7 +60,7 @@
<google-http-client.version>1.34.0</google-http-client.version>
<google-auth-library-oauth2-http.version>0.21.1</google-auth-library-oauth2-http.version> <!-- Mess in google-cloud-bom -->
<guava.version>29.0-jre</guava.version>
- <gson.version>2.8.5</gson.version>
+ <gson.version>2.8.6</gson.version><!-- JSONata -->
Review comment:
Could you plz change the comment to something like
```
<!-- 2.8.6 is required by JSONata; replace with ${gson-version} from camel-dependencies once https://issues.apache.org/jira/browse/CAMEL-15981 is fixed -->
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #2088: Added JSONata extension
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #2088:
URL: https://github.com/apache/camel-quarkus/pull/2088#discussion_r546598871
##########
File path: integration-tests/jsonata/src/main/resources/spec/expressions.json
##########
@@ -0,0 +1,5 @@
+{
+ "name": FirstName & " " & Surname,
+ "mobile": Phone[type = "mobile"].number
Review comment:
I see that this is supposed to be some sort of JSONata transformation recipe, but I still wonder whether it is valid JSON?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] oscerd commented on a change in pull request #2088: Added JSONata extension
Posted by GitBox <gi...@apache.org>.
oscerd commented on a change in pull request #2088:
URL: https://github.com/apache/camel-quarkus/pull/2088#discussion_r546643289
##########
File path: pom.xml
##########
@@ -60,7 +60,7 @@
<google-http-client.version>1.34.0</google-http-client.version>
<google-auth-library-oauth2-http.version>0.21.1</google-auth-library-oauth2-http.version> <!-- Mess in google-cloud-bom -->
<guava.version>29.0-jre</guava.version>
- <gson.version>2.8.5</gson.version>
+ <gson.version>2.8.6</gson.version><!-- JSONata -->
Review comment:
https://github.com/google/gson/issues/1677
This one is the latest one. It seems they will solve with 2.8.7, but there is no ETA
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger merged pull request #2088: Added JSONata extension
Posted by GitBox <gi...@apache.org>.
aldettinger merged pull request #2088:
URL: https://github.com/apache/camel-quarkus/pull/2088
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org