You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "deardeng (via GitHub)" <gi...@apache.org> on 2025/10/30 08:55:00 UTC
[PR] [fix](cloud) Fix virtual compute group expand the usage permissions o… [doris]
deardeng opened a new pull request, #57516:
URL: https://github.com/apache/doris/pull/57516
…f compute group
### What problem does this PR solve?
Fixed the logic for determining whether a regular compute group belongs to a specific virtual compute group; the compute group name needs to use the equal judgment.
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [x] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [x] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [x] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) Fix virtual compute group expand the usage permissions o… [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57516:
URL: https://github.com/apache/doris/pull/57516#issuecomment-3467075347
<details>
<summary>TPC-DS: <b>Total hot run time: 190736 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 3c7b20709d81329b307b83d1687dd8e7967d2c4e, data reload: false
query1 1080 462 406 406
query2 6558 1737 1701 1701
query3 6752 232 228 228
query4 26711 23907 23126 23126
query5 4436 648 507 507
query6 353 250 239 239
query7 4660 523 306 306
query8 318 280 281 280
query9 8748 2613 2578 2578
query10 498 371 304 304
query11 15854 15066 14880 14880
query12 183 122 122 122
query13 1692 566 453 453
query14 10903 9251 9324 9251
query15 218 190 189 189
query16 7628 669 560 560
query17 1223 757 624 624
query18 2051 442 372 372
query19 242 252 208 208
query20 140 129 138 129
query21 233 149 126 126
query22 4716 4866 4490 4490
query23 34971 34063 34024 34024
query24 8652 2511 2542 2511
query25 629 568 516 516
query26 1292 287 167 167
query27 2878 515 371 371
query28 4495 2235 2284 2235
query29 820 689 519 519
query30 316 252 214 214
query31 973 864 779 779
query32 92 79 78 78
query33 594 399 357 357
query34 835 902 548 548
query35 852 869 797 797
query36 1013 1049 943 943
query37 144 111 88 88
query38 3901 3678 3580 3580
query39 1557 1510 1465 1465
query40 236 137 121 121
query41 65 60 59 59
query42 121 110 114 110
query43 500 511 490 490
query44 1226 743 736 736
query45 183 183 173 173
query46 888 985 640 640
query47 1764 1798 1775 1775
query48 399 437 315 315
query49 772 500 416 416
query50 654 689 425 425
query51 3897 3964 3977 3964
query52 107 110 102 102
query53 235 267 197 197
query54 608 598 531 531
query55 90 89 83 83
query56 345 307 323 307
query57 1210 1190 1143 1143
query58 286 282 283 282
query59 2547 2649 2598 2598
query60 336 339 324 324
query61 155 159 157 157
query62 801 726 670 670
query63 231 191 196 191
query64 4493 1175 843 843
query65 4031 3939 3967 3939
query66 1134 432 322 322
query67 15297 15233 15213 15213
query68 8567 896 594 594
query69 489 322 294 294
query70 1425 1211 1257 1211
query71 518 346 335 335
query72 5925 4749 4820 4749
query73 725 573 352 352
query74 9221 8845 8982 8845
query75 4215 3346 2838 2838
query76 3732 1205 748 748
query77 840 399 312 312
query78 9681 9727 8908 8908
query79 2406 811 601 601
query80 634 556 502 502
query81 501 268 234 234
query82 482 165 142 142
query83 270 265 255 255
query84 266 109 109 109
query85 910 475 424 424
query86 391 305 306 305
query87 3693 3724 3706 3706
query88 3732 2228 2215 2215
query89 381 319 298 298
query90 1914 222 217 217
query91 176 169 138 138
query92 86 72 66 66
query93 1725 969 642 642
query94 710 454 338 338
query95 394 310 317 310
query96 499 565 277 277
query97 2908 2998 2863 2863
query98 251 211 218 211
query99 1358 1402 1300 1300
Total cold run time: 280847 ms
Total hot run time: 190736 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) Fix virtual compute group expand the usage permissions o… [doris]
Posted by "deardeng (via GitHub)" <gi...@apache.org>.
deardeng commented on PR #57516:
URL: https://github.com/apache/doris/pull/57516#issuecomment-3466731577
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) Fix virtual compute group expand the usage permissions o… [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #57516:
URL: https://github.com/apache/doris/pull/57516#issuecomment-3466737910
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) Fix virtual compute group expand the usage permissions o… [doris]
Posted by "Thearas (via GitHub)" <gi...@apache.org>.
Thearas commented on PR #57516:
URL: https://github.com/apache/doris/pull/57516#issuecomment-3466723360
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) Fix virtual compute group expand the usage permissions o… [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57516:
URL: https://github.com/apache/doris/pull/57516#issuecomment-3467105045
<details>
<summary>ClickBench: <b>Total hot run time: 27.72 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 3c7b20709d81329b307b83d1687dd8e7967d2c4e, data reload: false
query1 0.06 0.04 0.05
query2 0.10 0.05 0.05
query3 0.26 0.09 0.08
query4 1.62 0.12 0.12
query5 0.28 0.26 0.24
query6 1.16 0.67 0.64
query7 0.03 0.02 0.02
query8 0.05 0.05 0.05
query9 0.63 0.54 0.53
query10 0.58 0.59 0.58
query11 0.16 0.11 0.12
query12 0.16 0.12 0.12
query13 0.64 0.60 0.60
query14 1.00 1.01 1.00
query15 0.85 0.84 0.88
query16 0.41 0.42 0.39
query17 1.03 1.04 1.05
query18 0.23 0.20 0.20
query19 1.87 1.83 1.79
query20 0.01 0.01 0.01
query21 15.45 0.20 0.14
query22 4.98 0.08 0.05
query23 15.62 0.25 0.10
query24 2.92 0.94 0.42
query25 0.07 0.06 0.06
query26 0.15 0.14 0.13
query27 0.08 0.05 0.05
query28 4.83 1.12 0.92
query29 12.58 3.99 3.37
query30 0.29 0.14 0.11
query31 2.82 0.59 0.39
query32 3.23 0.54 0.46
query33 3.12 3.03 3.25
query34 15.72 5.11 4.59
query35 4.57 4.56 4.57
query36 0.69 0.52 0.49
query37 0.11 0.07 0.07
query38 0.07 0.05 0.04
query39 0.04 0.03 0.03
query40 0.16 0.16 0.15
query41 0.09 0.04 0.04
query42 0.04 0.03 0.04
query43 0.04 0.04 0.04
Total cold run time: 98.8 s
Total hot run time: 27.72 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) Fix virtual compute group expand the usage permissions o… [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #57516:
URL: https://github.com/apache/doris/pull/57516#issuecomment-3466738124
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) Fix virtual compute group expand the usage permissions o… [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen merged PR #57516:
URL: https://github.com/apache/doris/pull/57516
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org