You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/11/24 05:21:46 UTC
[GitHub] [dubbo-go] fangyincheng commented on a change in pull request #889: [WIP] Fix: heartbeat for server->client
fangyincheng commented on a change in pull request #889:
URL: https://github.com/apache/dubbo-go/pull/889#discussion_r529209853
##########
File path: remoting/getty/config.go
##########
@@ -188,6 +196,12 @@ func (c *ClientConfig) CheckValidity() error {
c.HeartbeatPeriod, time.Duration(config.MaxWheelTimeSpan))
}
+ if len(c.HeartbeatTimeout) == 0 {
+ c.heartbeatTimeout = 5 * time.Second
Review comment:
that is a test data， I will change it to 60s same as `Dubbo`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org