[GitHub] [lucene-solr] bruno-roustant commented on pull request #2302: LUCENE-9663: Adding compression to terms dict from SortedSet/Sorted D…

[GitBox <gi...@apache.org>]

bruno-roustant commented on pull request #2302:
URL: https://github.com/apache/lucene-solr/pull/2302#issuecomment-773991718


   @msokolov I confirm it is backward compatible, not thanks to TestDocValuesCompression#testMergeWithUncompressedSegment() but thanks to TestBackwardsCompatibility.testSearchOldIndex(). Indeed TestDocValuesCompression#testMergeWithUncompressedSegment writes and reads compressed/uncompressed with the new code. So it would not detect an incompatibility if, say 1 additional byte is written and read. However TestBackwardsCompatibility.testSearchOldIndex() reads and searches saved old indexes, including all DocValues types, so it would detect this 1 additional/missing byte incompatibility.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org