You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/03/28 09:34:04 UTC
[GitHub] [ozone] symious opened a new pull request #2087: HDDS-5035. Use default config values to solve generated config file conflict
symious opened a new pull request #2087:
URL: https://github.com/apache/ozone/pull/2087
## What changes were proposed in this pull request?
- Use default config values to initialize configurations
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5035
## How was this patch tested?
The user's assembled fat jar works fines now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] symious commented on pull request #2087: HDDS-5035. Use default config values to solve generated config file conflict
Posted by GitBox <gi...@apache.org>.
symious commented on pull request #2087:
URL: https://github.com/apache/ozone/pull/2087#issuecomment-811588033
@elek Thanks for the review, have added a unit test to simulate this case. Please have a check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] elek commented on pull request #2087: HDDS-5035. Use default config values to solve generated config file conflict
Posted by GitBox <gi...@apache.org>.
elek commented on pull request #2087:
URL: https://github.com/apache/ozone/pull/2087#issuecomment-814714163
> Sorry for not adding the unit test in the first place, it took some time to find a way to simulate the scenario for the unit test.
Sure, no problem. **Now** I understand that it was a tricky request, but earlier I thought it's a simpler problem ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] symious commented on pull request #2087: HDDS-5035. Use default config values to solve generated config file conflict
Posted by GitBox <gi...@apache.org>.
symious commented on pull request #2087:
URL: https://github.com/apache/ozone/pull/2087#issuecomment-809984538
@elek @adoroszlai Could you help to review this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] symious commented on pull request #2087: HDDS-5035. Use default config values to solve generated config file conflict
Posted by GitBox <gi...@apache.org>.
symious commented on pull request #2087:
URL: https://github.com/apache/ozone/pull/2087#issuecomment-814553449
@elek Thanks for the review.
Sorry for not adding the unit test in the first place, it took some time to find a way to simulate the scenario for the unit test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] elek merged pull request #2087: HDDS-5035. Use default config values to solve generated config file conflict
Posted by GitBox <gi...@apache.org>.
elek merged pull request #2087:
URL: https://github.com/apache/ozone/pull/2087
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org