[GitHub] [sling-site] bdelacretaz commented on a change in pull request #50: SLING-9795 - JUnit 5 support for server-side tests

[GitBox <gi...@apache.org>]

bdelacretaz commented on a change in pull request #50:
URL: https://github.com/apache/sling-site/pull/50#discussion_r506309019



##########
File path: src/main/jbake/content/documentation/bundles/org-apache-sling-junit-bundles.md
##########
@@ -27,6 +27,42 @@ the test class names, like for example:
 
     Sling-Test-Regexp=com.example.*ServerSideTest
 
+### JUnit 4 Support
+All that is required is the installation of the the Apache Sling JUnit Core bundle. The bundle exports the packages `junit.*`, `org.junit.*` and additionally `org.hamcrest.*`. Note however that the `org.junit.platform.*` packages, which contain the generic testing platform developed for JUnit 5, are NOT exported.  
+
+### JUnit 5 Support (since version 1.1.0)
+JUnit 5 support requires installation of a number of bundles provided by the JUnit team. The Apache Sling JUnit Core bundle has optional imports for some of the packages exported by these bundles and will automatically switch to JUnit 5 support if these are available (a bundle restart is required).

Review comment:
       "automatically switch to JUnit 5" might imply that JUnit 4 tests stop working when that switch is done.
   
   If that's not the case I would say "automatically activate JUnit 5 support" instead.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org