RA checkouts

[Ben Collins-Sussman <su...@newton.ch.collab.net>]

Hey gstein, look at our declaration for RA checkouts in svn_ra.h:

  /* Ask the network layer to check out a copy of the repository URL
     specified in open(), using EDITOR and EDIT_BATON to create a
     working copy. */
  svn_error_t *(*do_checkout) (void *session_baton,
                               const svn_delta_edit_fns_t *editor,
                               void *edit_baton);

Don't we want the ability to checkout a certain revision of a project?
I'd like to put a REVISION arg in there.  (If == SVN_INVALID_REVNUM,
the latest rev will be retrieved.)

Re: RA checkouts

[Greg Stein <gs...@lyra.org>]

[ back from a short jaunt... catching up on email now... ]

On Wed, Mar 14, 2001 at 03:23:17PM -0600, Ben Collins-Sussman wrote:
> Ben Collins-Sussman <su...@newton.ch.collab.net> writes:
> > Hey gstein, look at our declaration for RA checkouts in svn_ra.h:
> > 
> >   /* Ask the network layer to check out a copy of the repository URL
> >      specified in open(), using EDITOR and EDIT_BATON to create a
> >      working copy. */
> >   svn_error_t *(*do_checkout) (void *session_baton,
> >                                const svn_delta_edit_fns_t *editor,
> >                                void *edit_baton);
> > 
> > Don't we want the ability to checkout a certain revision of a project?
> > I'd like to put a REVISION arg in there.  (If == SVN_INVALID_REVNUM,
> > the latest rev will be retrieved.)
> 
> Or maybe the revision number can be passed in with the URL given to
> ra->open, and thus implicitly stashed in the session_baton... ?

The revision argument should be a checkout parameter. open() is talking
about creating a session, and I don't think REV has a place there.

I would agree that SVN_INVALID_REVNUM would meant "latest". I'd also think
creating SVN_LATEST_REVNUM would be fine.

The RA interface could also grow a new query functions: get_revnum_by_date.
We don't have tags, so there isn't a need for revnum_by_name or somesuch.
The interface already has get_latest_revnum; not exactly sure where that
will play, but it can be left for now.

Note that checkout() also needs a recursion flag (corresponding to "-l" in
CVS).

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/

Re: RA checkouts

[Ben Collins-Sussman <su...@newton.ch.collab.net>]

Ben Collins-Sussman <su...@newton.ch.collab.net> writes:

> Hey gstein, look at our declaration for RA checkouts in svn_ra.h:
> 
>   /* Ask the network layer to check out a copy of the repository URL
>      specified in open(), using EDITOR and EDIT_BATON to create a
>      working copy. */
>   svn_error_t *(*do_checkout) (void *session_baton,
>                                const svn_delta_edit_fns_t *editor,
>                                void *edit_baton);
> 
> Don't we want the ability to checkout a certain revision of a project?
> I'd like to put a REVISION arg in there.  (If == SVN_INVALID_REVNUM,
> the latest rev will be retrieved.)

Or maybe the revision number can be passed in with the URL given to
ra->open, and thus implicitly stashed in the session_baton... ?