You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@carbondata.apache.org by akashrn5 <gi...@git.apache.org> on 2018/01/19 15:12:57 UTC

[GitHub] carbondata pull request #1838: [CARBONDATA-2060]fix insert overwrite on part...

GitHub user akashrn5 opened a pull request:

    https://github.com/apache/carbondata/pull/1838

    [CARBONDATA-2060]fix insert overwrite on partition table

    Be sure to do all of the following checklist to help us incorporate 
    your contribution quickly and easily:
    
    Problem:
    when insert overwrite is done on partition table with the table which has empty data, it was not overwriting.
    
    Solution: 
    when insert OverWrite is fired on partition table from empty table, it should create new empty segment and it should delete old segments.
    
     - [X] Any interfaces changed?
    NA
     
     - [X] Any backward compatibility impacted?
    NA
     
     - [X] Document update required?
    NA
    
     - [X] Testing done
    Unit tests cases are added to test the scenario
            Please provide details on 
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [x] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. 
    NA
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/akashrn5/incubator-carbondata partition_overwrite

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1838.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1838
    
----
commit 56e3054ade07bfd39e7ec1050fe2962166d4ad23
Author: akashrn5 <ak...@...>
Date:   2018-01-19T14:57:05Z

    fix insert overwrite on partition table

----


---

[GitHub] carbondata issue #1838: [CARBONDATA-2060]fix insert overwrite on partition t...

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1838
  
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1786/



---

[GitHub] carbondata issue #1838: [CARBONDATA-2060]fix insert overwrite on partition t...

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1838
  
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3066/



---

[GitHub] carbondata issue #1838: [CARBONDATA-2060]fix insert overwrite on partition t...

Posted by ravipesala <gi...@git.apache.org>.

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1838
  
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3007/



---

[GitHub] carbondata issue #1838: [CARBONDATA-2060]fix insert overwrite on partition t...

Posted by manishgupta88 <gi...@git.apache.org>.

Github user manishgupta88 commented on the issue:

    https://github.com/apache/carbondata/pull/1838
  
    LGTM


---

[GitHub] carbondata issue #1838: [CARBONDATA-2060]fix insert overwrite on partition t...

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1838
  
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1768/



---

[GitHub] carbondata issue #1838: [CARBONDATA-2060]fix insert overwrite on partition t...

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1838
  
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3026/



---

[GitHub] carbondata issue #1838: [CARBONDATA-2060]fix insert overwrite on partition t...

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1838
  
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3017/



---

[GitHub] carbondata issue #1838: [CARBONDATA-2060]fix insert overwrite on partition t...

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1838
  
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1825/



---

[GitHub] carbondata issue #1838: [CARBONDATA-2060]fix insert overwrite on partition t...

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1838
  
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2998/



---

[GitHub] carbondata issue #1838: [CARBONDATA-2060]fix insert overwrite on partition t...

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1838
  
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1795/



---

[GitHub] carbondata issue #1838: [CARBONDATA-2060]fix insert overwrite on partition t...

Posted by akashrn5 <gi...@git.apache.org>.

Github user akashrn5 commented on the issue:

    https://github.com/apache/carbondata/pull/1838
  
    retest this please


---

[GitHub] carbondata issue #1838: [CARBONDATA-2060]fix insert overwrite on partition t...

Posted by ravipesala <gi...@git.apache.org>.

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1838
  
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3026/



---