You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/08/26 23:50:55 UTC

[GitHub] [orc] belugabehr commented on a change in pull request #754: ORC-852: Allow DynamicByteArray to Return a ByteBuffer

belugabehr commented on a change in pull request #754:
URL: https://github.com/apache/orc/pull/754#discussion_r697049931



##########
File path: java/core/src/java/org/apache/orc/impl/DictionaryUtils.java
##########
@@ -46,6 +47,18 @@ public static void getTextInternal(Text result, int position,
     byteArray.setText(result, offset, length);
   }
 
+  public static ByteBuffer getTextInternal(int position, DynamicIntArray keyOffsets,

Review comment:
       I think overloading a method with different return types is more proper here. (I think we should keep as is).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org