You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Reza Motamedi <re...@gmail.com> on 2017/06/06 22:44:55 UTC
Review Request 59864: Allow disk monitoring to be disabled in Thermos
Executor
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59864/
-----------------------------------------------------------
Review request for Aurora, David McLaughlin and Santhosh Kumar Shanmugham.
Repository: aurora
Description
-------
# Allow disk monitoring to be disabled in Thermos Executor
related tickets:
- https://issues.apache.org/jira/browse/AURORA-1033
- https://issues.apache.org/jira/browse/AURORA-1918
https://docs.google.com/document/d/1-1eYenw9wgsWXyyOWn32l0oJBBXpzIN5V20vi0AZpi8/edit?usp=sharing
This RB is related to part(1) of the above document. As I learned recently, the community favors disabling the disk monitoring in the Observer as well, and this would be addressed in part(2). I think it is possible to keep the current bahavior by asking the Mesos Agent, but for sure disabling the monitoring is the easiest way.
Diffs
-----
src/main/python/apache/aurora/executor/bin/thermos_executor_main.py c6c08983fb2d204afedd419798135d667169bce4
src/main/python/apache/aurora/executor/common/resource_manager.py b7dc40d8973ec2e5998ab4f6ff988051a70bb1ab
Diff: https://reviews.apache.org/r/59864/diff/1/
Testing
-------
I tested this by running `./build-support/jenkins/build.sh` and it passed.
I also modified
`-thermos_executor_flags="--announcer-ensemble localhost:2181 --announcer-zookeeper-auth-config /home/vagrant/aurora/examples/vagrant/config/announcer-auth.json --mesos-containerizer-path=/u sr/libexec/mesos/mesos-containerizer"`
to
`-thermos_executor_flags="--announcer-ensemble localhost:2181 --announcer-zookeeper-auth-config /home/vagrant/aurora/examples/vagrant/config/announcer-auth.json --mesos-containerizer-path=/u sr/libexec/mesos/mesos-containerizer --disable-disk-monitor"`
in `examples/vagrant/upstart/aurora-scheduler.conf` and the falg is being picked up and the task is executed.
Thanks,
Reza Motamedi
Re: Review Request 59864: Allow disk monitoring to be disabled in
Thermos Executor
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59864/#review177120
-----------------------------------------------------------
Master (73234d0) is green with this patch.
./build-support/jenkins/build.sh
However, it appears that it might lack test coverage.
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On June 6, 2017, 10:44 p.m., Reza Motamedi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59864/
> -----------------------------------------------------------
>
> (Updated June 6, 2017, 10:44 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Santhosh Kumar Shanmugham.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> # Allow disk monitoring to be disabled in Thermos Executor
>
> related tickets:
> - https://issues.apache.org/jira/browse/AURORA-1033
> - https://issues.apache.org/jira/browse/AURORA-1918
>
> https://docs.google.com/document/d/1-1eYenw9wgsWXyyOWn32l0oJBBXpzIN5V20vi0AZpi8/edit?usp=sharing
>
> This RB is related to part(1) of the above document. As I learned recently, the community favors disabling the disk monitoring in the Observer as well, and this would be addressed in part(2). I think it is possible to keep the current bahavior by asking the Mesos Agent, but for sure disabling the monitoring is the easiest way.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/bin/thermos_executor_main.py c6c08983fb2d204afedd419798135d667169bce4
> src/main/python/apache/aurora/executor/common/resource_manager.py b7dc40d8973ec2e5998ab4f6ff988051a70bb1ab
>
>
> Diff: https://reviews.apache.org/r/59864/diff/1/
>
>
> Testing
> -------
>
> I tested this by running `./build-support/jenkins/build.sh` and it passed.
>
> I also modified
> `-thermos_executor_flags="--announcer-ensemble localhost:2181 --announcer-zookeeper-auth-config /home/vagrant/aurora/examples/vagrant/config/announcer-auth.json --mesos-containerizer-path=/u sr/libexec/mesos/mesos-containerizer"`
> to
> `-thermos_executor_flags="--announcer-ensemble localhost:2181 --announcer-zookeeper-auth-config /home/vagrant/aurora/examples/vagrant/config/announcer-auth.json --mesos-containerizer-path=/u sr/libexec/mesos/mesos-containerizer --disable-disk-monitor"`
> in `examples/vagrant/upstart/aurora-scheduler.conf` and the falg is being picked up and the task is executed.
>
>
> Thanks,
>
> Reza Motamedi
>
>