You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@synapse.apache.org by ru...@apache.org on 2010/05/16 12:00:40 UTC
svn commit: r944786 -
/synapse/trunk/java/modules/transports/core/nhttp/src/main/java/org/apache/synapse/transport/nhttp/ClientHandler.java
Author: ruwan
Date: Sun May 16 10:00:40 2010
New Revision: 944786
URL: http://svn.apache.org/viewvc?rev=944786&view=rev
Log:
Fixing the correct collection of the request completion time
Modified:
synapse/trunk/java/modules/transports/core/nhttp/src/main/java/org/apache/synapse/transport/nhttp/ClientHandler.java
Modified: synapse/trunk/java/modules/transports/core/nhttp/src/main/java/org/apache/synapse/transport/nhttp/ClientHandler.java
URL: http://svn.apache.org/viewvc/synapse/trunk/java/modules/transports/core/nhttp/src/main/java/org/apache/synapse/transport/nhttp/ClientHandler.java?rev=944786&r1=944785&r2=944786&view=diff
==============================================================================
--- synapse/trunk/java/modules/transports/core/nhttp/src/main/java/org/apache/synapse/transport/nhttp/ClientHandler.java (original)
+++ synapse/trunk/java/modules/transports/core/nhttp/src/main/java/org/apache/synapse/transport/nhttp/ClientHandler.java Sun May 16 10:00:40 2010
@@ -562,14 +562,6 @@ public class ClientHandler implements NH
} else {
metrics.incrementBytesSent(bytesWritten);
}
-
- // TODO: executing this when metrics != 0 && bytesWritten > 0 seems strange;
- // shouldn't the condition be encoder.isCompleted() ?!?!?
- ClientConnectionDebug ccd = (ClientConnectionDebug)
- context.getAttribute(CLIENT_CONNECTION_DEBUG);
- if (ccd != null) {
- ccd.recordRequestCompletionTime();
- }
}
if (encoder.isCompleted()) {
@@ -581,6 +573,14 @@ public class ClientHandler implements NH
}
}
+ if (encoder.isCompleted()) {
+ ClientConnectionDebug ccd = (ClientConnectionDebug)
+ context.getAttribute(CLIENT_CONNECTION_DEBUG);
+ if (ccd != null) {
+ ccd.recordRequestCompletionTime();
+ }
+ }
+
} catch (IOException e) {
if (metrics != null) {
if (metrics.getLevel() == MetricsCollector.LEVEL_FULL) {