You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "Revanth14 (via GitHub)" <gi...@apache.org> on 2026/10/19 15:35:19 UTC
[PR] fix(io): accept a trailing slash on the blobfs WalkDir root [iceberg-go]
Revanth14 opened a new pull request, #2218:
URL: https://github.com/apache/iceberg-go/pull/2218
## Problem
`blobfs.FileIO.WalkDir("s3://bucket/tbl/")` failed with `stat tbl/: invalid argument` before visiting anything: the key `tbl/` went straight to `fs.WalkDir`, which rejects it via `fs.ValidPath`. Orphan cleanup returns walk errors, so a cleanup location written with a trailing slash failed the whole scan.
## Fix
`WalkDir` trims trailing `/` from the key before walking. A key that is empty after trimming walks the bucket root, as an empty key already does. Walked paths come back without the slash, so reported URIs are the same as for the root without one.
## Testing
`TestBlobFileIOWalkDirTrailingSlashRoot` walks `tbl`, `tbl/` and `tbl//` and checks all three report the same paths. Without the trim it fails with the reported error. `go test -race ./io/... ./table/maintenance/...` passes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] fix(io): accept a trailing slash on the blobfs WalkDir root [iceberg-go]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade merged PR #2218:
URL: https://github.com/apache/iceberg-go/pull/2218
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org