You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@reef.apache.org by Markus Weimer <ma...@weimo.de> on 2015/08/28 19:34:39 UTC
REEF.NET namespace rationale?
Hi,
I've been scanning through some of the REEF.NET APIs for
inconsistencies. (See the many JIRAs I just filled :-) )
One thing that I couldn't reconcile is how we assign things between
Org.Apache.REEF.Common and other namespaces. For instance, we have
`Org.Apache.REEF.Common.IContextSubmittable`, but the only possible use
for it is in the Driver, where all its extending interfaces and
implementations reside.
What's the rationale for this split? How do we decide what to put where?
If we wanted to do something about this, we might consider making a
*breaking* release, as there are just too many things to clean up.
Thoughts?
Markus
Re: REEF.NET namespace rationale?
Posted by Markus Weimer <ma...@weimo.de>.
On 2015-08-28 12:53, Julia Wang (QIUHE) wrote:
> What is the criteria for defining what should be in Common and what
> should be Driver?
My question exactly. The current situation is confusing to the point
that we managed to have two `IRunningTask` interfaces with (seemingly)
identical contents.
> For anything that defined in Common but only used in Driver, should
> we move all of them from Common to Driver?
That is a reasonable approach, at the very least as far as namespaces
are concerned. Also, far too much of the code is currently `public` when
it really should be `internal`.
Markus
RE: REEF.NET namespace rationale?
Posted by "Julia Wang (QIUHE)" <Qi...@microsoft.com>.
What is the criteria for defining what should be in Common and what should be Driver? For anything that defined in Common but only used in Driver, should we move all of them from Common to Driver?
-----Original Message-----
From: Markus Weimer [mailto:markus@weimo.de]
Sent: Friday, August 28, 2015 10:35 AM
To: REEF Developers Mailinglist <de...@reef.incubator.apache.org>
Subject: REEF.NET namespace rationale?
Hi,
I've been scanning through some of the REEF.NET APIs for inconsistencies. (See the many JIRAs I just filled :-) )
One thing that I couldn't reconcile is how we assign things between Org.Apache.REEF.Common and other namespaces. For instance, we have `Org.Apache.REEF.Common.IContextSubmittable`, but the only possible use for it is in the Driver, where all its extending interfaces and implementations reside.
What's the rationale for this split? How do we decide what to put where?
If we wanted to do something about this, we might consider making a
*breaking* release, as there are just too many things to clean up.
Thoughts?
Markus