You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Ivan Volosyuk (JIRA)" <ji...@apache.org> on 2006/10/10 13:40:19 UTC
[jira] Created: (HARMONY-1810) [DRLVM][GC] jvmti heap iteration
support in gcv41
[DRLVM][GC] jvmti heap iteration support in gcv41
-------------------------------------------------
Key: HARMONY-1810
URL: http://issues.apache.org/jira/browse/HARMONY-1810
Project: Harmony
Issue Type: New Feature
Components: DRLVM
Environment: All
Reporter: Ivan Volosyuk
JVMTI heap iteration support implementation for GC v4.1
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1810) [DRLVM][GC] jvmti heap iteration
support in gcv41
Posted by "Salikh Zakirov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1810?page=comments#action_12442029 ]
Salikh Zakirov commented on HARMONY-1810:
-----------------------------------------
It looks like the special root vector is never cleared, which leads to assertion failures on 2nd garbage collection.
The following fix worked for me. Ivan, could you please update the patch with the fix? Thanks
--- vm/gc_cc/src/collect_slide_compact.cpp
+++ vm/gc_cc/src/collect_slide_compact.cpp
@@ -648,6 +649,7 @@ void gc_slide_process_special_roots(slot
*ref = NULL;
}
}
+ array.clear();
}
void gc_slide_postprocess_special_references(reference_vector& array) {
> [DRLVM][GC] jvmti heap iteration support in gcv41
> -------------------------------------------------
>
> Key: HARMONY-1810
> URL: http://issues.apache.org/jira/browse/HARMONY-1810
> Project: Harmony
> Issue Type: New Feature
> Components: DRLVM
> Environment: All
> Reporter: Ivan Volosyuk
> Attachments: gcv41_heap_iteration.diff
>
>
> JVMTI heap iteration support implementation for GC v4.1
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1810) [DRLVM][GC] jvmti heap iteration
support in gcv41
Posted by "Salikh Zakirov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1810?page=comments#action_12441737 ]
Salikh Zakirov commented on HARMONY-1810:
-----------------------------------------
The code in gcv41_heap_iteration.diff checks for the gc.heap_iteration property in gc_vm_initialized(),
while this function is never called.
To run heap iteration test with gcv41 I used workaround to move the property check to gc_init() function.
> [DRLVM][GC] jvmti heap iteration support in gcv41
> -------------------------------------------------
>
> Key: HARMONY-1810
> URL: http://issues.apache.org/jira/browse/HARMONY-1810
> Project: Harmony
> Issue Type: New Feature
> Components: DRLVM
> Environment: All
> Reporter: Ivan Volosyuk
> Attachments: gcv41_heap_iteration.diff
>
>
> JVMTI heap iteration support implementation for GC v4.1
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (HARMONY-1810) [DRLVM][GC] jvmti heap iteration
support in gcv41
Posted by "Geir Magnusson Jr (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1810?page=all ]
Geir Magnusson Jr resolved HARMONY-1810.
----------------------------------------
Resolution: Fixed
r470923
Ubuntu 6 = smoke,c-unit, ~kernel
> [DRLVM][GC] jvmti heap iteration support in gcv41
> -------------------------------------------------
>
> Key: HARMONY-1810
> URL: http://issues.apache.org/jira/browse/HARMONY-1810
> Project: Harmony
> Issue Type: New Feature
> Components: DRLVM
> Environment: All
> Reporter: Ivan Volosyuk
> Assigned To: Geir Magnusson Jr
> Attachments: gcv41_heap_iteration.diff, gcv41_heap_iteration2.diff
>
>
> JVMTI heap iteration support implementation for GC v4.1
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (HARMONY-1810) [DRLVM][GC] jvmti heap iteration
support in gcv41
Posted by "Geir Magnusson Jr (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1810?page=all ]
Geir Magnusson Jr reassigned HARMONY-1810:
------------------------------------------
Assignee: Geir Magnusson Jr
> [DRLVM][GC] jvmti heap iteration support in gcv41
> -------------------------------------------------
>
> Key: HARMONY-1810
> URL: http://issues.apache.org/jira/browse/HARMONY-1810
> Project: Harmony
> Issue Type: New Feature
> Components: DRLVM
> Environment: All
> Reporter: Ivan Volosyuk
> Assigned To: Geir Magnusson Jr
> Attachments: gcv41_heap_iteration.diff, gcv41_heap_iteration2.diff
>
>
> JVMTI heap iteration support implementation for GC v4.1
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1810) [DRLVM][GC] jvmti heap iteration
support in gcv41
Posted by "Salikh Zakirov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1810?page=comments#action_12445213 ]
Salikh Zakirov commented on HARMONY-1810:
-----------------------------------------
special roots array needs to be cleared in 2 places. Additional fix below:
--- vm/gc_cc/src/collect.cpp
+++ vm/gc_cc/src/collect.cpp
@@ -216,6 +216,7 @@ void process_special_roots(slots_vector&
// object not marked, clear ref
*ref = 0;
}
+ array.clear();
}
void process_special_references(reference_vector& array) {
> [DRLVM][GC] jvmti heap iteration support in gcv41
> -------------------------------------------------
>
> Key: HARMONY-1810
> URL: http://issues.apache.org/jira/browse/HARMONY-1810
> Project: Harmony
> Issue Type: New Feature
> Components: DRLVM
> Environment: All
> Reporter: Ivan Volosyuk
> Attachments: gcv41_heap_iteration.diff
>
>
> JVMTI heap iteration support implementation for GC v4.1
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1810) [DRLVM][GC] jvmti heap iteration
support in gcv41
Posted by "Geir Magnusson Jr (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1810?page=comments#action_12444525 ]
Geir Magnusson Jr commented on HARMONY-1810:
--------------------------------------------
this patch doesn't apply cleanly anyway...
> [DRLVM][GC] jvmti heap iteration support in gcv41
> -------------------------------------------------
>
> Key: HARMONY-1810
> URL: http://issues.apache.org/jira/browse/HARMONY-1810
> Project: Harmony
> Issue Type: New Feature
> Components: DRLVM
> Environment: All
> Reporter: Ivan Volosyuk
> Attachments: gcv41_heap_iteration.diff
>
>
> JVMTI heap iteration support implementation for GC v4.1
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-1810) [DRLVM][GC] jvmti heap iteration
support in gcv41
Posted by "Ivan Volosyuk (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1810?page=all ]
Ivan Volosyuk updated HARMONY-1810:
-----------------------------------
Attachment: gcv41_heap_iteration2.diff
Updated patch attached.
Fixed issues mentioned by Salikh in handling of weak roots.
Fixed compilation on EM64T.
> [DRLVM][GC] jvmti heap iteration support in gcv41
> -------------------------------------------------
>
> Key: HARMONY-1810
> URL: http://issues.apache.org/jira/browse/HARMONY-1810
> Project: Harmony
> Issue Type: New Feature
> Components: DRLVM
> Environment: All
> Reporter: Ivan Volosyuk
> Attachments: gcv41_heap_iteration.diff, gcv41_heap_iteration2.diff
>
>
> JVMTI heap iteration support implementation for GC v4.1
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (HARMONY-1810) [DRLVM][GC] jvmti heap iteration
support in gcv41
Posted by "Geir Magnusson Jr (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1810?page=all ]
Geir Magnusson Jr closed HARMONY-1810.
--------------------------------------
> [DRLVM][GC] jvmti heap iteration support in gcv41
> -------------------------------------------------
>
> Key: HARMONY-1810
> URL: http://issues.apache.org/jira/browse/HARMONY-1810
> Project: Harmony
> Issue Type: New Feature
> Components: DRLVM
> Environment: All
> Reporter: Ivan Volosyuk
> Assigned To: Geir Magnusson Jr
> Attachments: gcv41_heap_iteration.diff, gcv41_heap_iteration2.diff
>
>
> JVMTI heap iteration support implementation for GC v4.1
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-1810) [DRLVM][GC] jvmti heap iteration
support in gcv41
Posted by "Ivan Volosyuk (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1810?page=all ]
Ivan Volosyuk updated HARMONY-1810:
-----------------------------------
Attachment: gcv41_heap_iteration.diff
Implemented jvmti heap iteration for GC v4.1
For performance considerations it is not enabled by default.
To enable it use java property:
-Dgc.heap_iteration=true
This property will be set in jvmti initialization code.
To enable jvmti heap iteration on demand the VM<>GC interface function is required. It will possibly switch algorithm the GC use or may cause immediate garbage collection.
Tested on Linux/x86, Window/x86. Need to check EM64T build.
> [DRLVM][GC] jvmti heap iteration support in gcv41
> -------------------------------------------------
>
> Key: HARMONY-1810
> URL: http://issues.apache.org/jira/browse/HARMONY-1810
> Project: Harmony
> Issue Type: New Feature
> Components: DRLVM
> Environment: All
> Reporter: Ivan Volosyuk
> Attachments: gcv41_heap_iteration.diff
>
>
> JVMTI heap iteration support implementation for GC v4.1
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1810) [DRLVM][GC] jvmti heap iteration
support in gcv41
Posted by "Ivan Volosyuk (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1810?page=comments#action_12444639 ]
Ivan Volosyuk commented on HARMONY-1810:
----------------------------------------
The patch seems to be outdated by other changes. I will address this soon.
> [DRLVM][GC] jvmti heap iteration support in gcv41
> -------------------------------------------------
>
> Key: HARMONY-1810
> URL: http://issues.apache.org/jira/browse/HARMONY-1810
> Project: Harmony
> Issue Type: New Feature
> Components: DRLVM
> Environment: All
> Reporter: Ivan Volosyuk
> Attachments: gcv41_heap_iteration.diff
>
>
> JVMTI heap iteration support implementation for GC v4.1
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1810) [DRLVM][GC] jvmti heap iteration
support in gcv41
Posted by "Geir Magnusson Jr (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1810?page=comments#action_12444456 ]
Geir Magnusson Jr commented on HARMONY-1810:
--------------------------------------------
Ivan, are you going to address Salikh's comment? Is a fix needed?
> [DRLVM][GC] jvmti heap iteration support in gcv41
> -------------------------------------------------
>
> Key: HARMONY-1810
> URL: http://issues.apache.org/jira/browse/HARMONY-1810
> Project: Harmony
> Issue Type: New Feature
> Components: DRLVM
> Environment: All
> Reporter: Ivan Volosyuk
> Attachments: gcv41_heap_iteration.diff
>
>
> JVMTI heap iteration support implementation for GC v4.1
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1810) [DRLVM][GC] jvmti heap iteration
support in gcv41
Posted by "Geir Magnusson Jr (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1810?page=comments#action_12445370 ]
Geir Magnusson Jr commented on HARMONY-1810:
--------------------------------------------
we need this one fixed as its a blocker for other things
> [DRLVM][GC] jvmti heap iteration support in gcv41
> -------------------------------------------------
>
> Key: HARMONY-1810
> URL: http://issues.apache.org/jira/browse/HARMONY-1810
> Project: Harmony
> Issue Type: New Feature
> Components: DRLVM
> Environment: All
> Reporter: Ivan Volosyuk
> Attachments: gcv41_heap_iteration.diff
>
>
> JVMTI heap iteration support implementation for GC v4.1
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira