You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Brock Noland <br...@cloudera.com> on 2012/11/19 20:42:48 UTC
Review Request: FLUME-1502: Support for running simple configurations
embedded in host process
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8127/
-----------------------------------------------------------
Review request for Flume.
Description
-------
Patch is on top of the FLUME-1502 branch which has 1630 committed to it.
This patch creates a module flume-ng-embedded-agent which implements FLUME-1502. The patch is not read for commit. Specifically, it needs the following:
1) whitespace removal
2) docs in package-info.java and the developer guide
However, I'd like to start soliciting feedback as these are not items which will affect it's overall design.
This addresses bug FLUME-1502.
https://issues.apache.org/jira/browse/FLUME-1502
Diffs
-----
flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java 9b209e8
flume-ng-core/src/main/java/org/apache/flume/sink/SinkProcessorFactory.java f39b919
flume-ng-core/src/main/java/org/apache/flume/source/AvroSource.java 47ccf9f
flume-ng-dist/pom.xml d929c88
flume-ng-embedded-agent/pom.xml PRE-CREATION
flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/AvroLocalSource.java PRE-CREATION
flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/EmbeddedAgent.java PRE-CREATION
flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/EmbeddedAgentConfiguration.java PRE-CREATION
flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/EmbeddedSource.java PRE-CREATION
flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/LocalSource.java PRE-CREATION
flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/MaterializedConfigurationProvider.java PRE-CREATION
flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/MemoryConfigurationProvider.java PRE-CREATION
flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/package-info.java PRE-CREATION
flume-ng-embedded-agent/src/test/java/org/apache/flume/agent/embedded/TestEmbeddedAgentAvroSource.java PRE-CREATION
flume-ng-embedded-agent/src/test/java/org/apache/flume/agent/embedded/TestEmbeddedAgentConfiguration.java PRE-CREATION
flume-ng-embedded-agent/src/test/java/org/apache/flume/agent/embedded/TestEmbeddedAgentEmbeddedSource.java PRE-CREATION
flume-ng-embedded-agent/src/test/java/org/apache/flume/agent/embedded/TestEmbeddedAgentState.java PRE-CREATION
flume-ng-embedded-agent/src/test/resources/log4j.properties PRE-CREATION
pom.xml 76b8351
Diff: https://reviews.apache.org/r/8127/diff/
Testing
-------
Additional unit tests have been added and they pass.
Thanks,
Brock Noland
Re: Review Request: FLUME-1502: Support for running simple configurations
embedded in host process
Posted by Brock Noland <br...@cloudera.com>.
> On Dec. 11, 2012, 8:06 p.m., Mike Percy wrote:
> > Brock, thanks for updating the patch! I'm getting a unit test error on org.apache.flume.agent.embedded.TestEmbeddedAgentConfiguration:
> >
> > testNoSource(org.apache.flume.agent.embedded.TestEmbeddedAgentConfiguration) Time elapsed: 0.005 sec <<< FAILURE!
> > java.lang.AssertionError: Expected exception: org.apache.flume.FlumeException
> > at org.junit.internal.runners.statements.ExpectException.evaluate(ExpectException.java:35)
> > at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28)
> > at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:263)
Yeah that was dumb on my part, that test is no longer relevant. Updated patch without it shortly.
- Brock
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8127/#review14303
-----------------------------------------------------------
On Dec. 10, 2012, 8:36 p.m., Brock Noland wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8127/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2012, 8:36 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Patch is on top of the FLUME-1502 branch which has 1630 committed to it.
>
> This patch creates a module flume-ng-embedded-agent which implements FLUME-1502. The patch is not read for commit. Specifically, it needs the following:
>
> 1) whitespace removal
> 2) docs in package-info.java and the developer guide
>
> However, I'd like to start soliciting feedback as these are not items which will affect it's overall design.
>
>
> This addresses bug FLUME-1502.
> https://issues.apache.org/jira/browse/FLUME-1502
>
>
> Diffs
> -----
>
> flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java 5d56599
> flume-ng-core/src/main/java/org/apache/flume/sink/SinkProcessorFactory.java f39b919
> flume-ng-dist/pom.xml d929c88
> flume-ng-doc/sphinx/FlumeDeveloperGuide.rst f52970b
> flume-ng-embedded-agent/pom.xml PRE-CREATION
> flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/EmbeddedAgent.java PRE-CREATION
> flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/EmbeddedAgentConfiguration.java PRE-CREATION
> flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/EmbeddedSource.java PRE-CREATION
> flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/MaterializedConfigurationProvider.java PRE-CREATION
> flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/MemoryConfigurationProvider.java PRE-CREATION
> flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/package-info.java PRE-CREATION
> flume-ng-embedded-agent/src/test/java/org/apache/flume/agent/embedded/TestEmbeddedAgent.java PRE-CREATION
> flume-ng-embedded-agent/src/test/java/org/apache/flume/agent/embedded/TestEmbeddedAgentConfiguration.java PRE-CREATION
> flume-ng-embedded-agent/src/test/java/org/apache/flume/agent/embedded/TestEmbeddedAgentEmbeddedSource.java PRE-CREATION
> flume-ng-embedded-agent/src/test/java/org/apache/flume/agent/embedded/TestEmbeddedAgentState.java PRE-CREATION
> flume-ng-embedded-agent/src/test/resources/log4j.properties PRE-CREATION
> flume-ng-node/src/main/java/org/apache/flume/node/MaterializedConfiguration.java 674fb38
> pom.xml 53ac96b
>
> Diff: https://reviews.apache.org/r/8127/diff/
>
>
> Testing
> -------
>
> Additional unit tests have been added and they pass.
>
>
> Thanks,
>
> Brock Noland
>
>
Re: Review Request: FLUME-1502: Support for running simple configurations
embedded in host process
Posted by Mike Percy <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8127/#review14303
-----------------------------------------------------------
Brock, thanks for updating the patch! I'm getting a unit test error on org.apache.flume.agent.embedded.TestEmbeddedAgentConfiguration:
testNoSource(org.apache.flume.agent.embedded.TestEmbeddedAgentConfiguration) Time elapsed: 0.005 sec <<< FAILURE!
java.lang.AssertionError: Expected exception: org.apache.flume.FlumeException
at org.junit.internal.runners.statements.ExpectException.evaluate(ExpectException.java:35)
at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:263)
- Mike Percy
On Dec. 10, 2012, 8:36 p.m., Brock Noland wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8127/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2012, 8:36 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Patch is on top of the FLUME-1502 branch which has 1630 committed to it.
>
> This patch creates a module flume-ng-embedded-agent which implements FLUME-1502. The patch is not read for commit. Specifically, it needs the following:
>
> 1) whitespace removal
> 2) docs in package-info.java and the developer guide
>
> However, I'd like to start soliciting feedback as these are not items which will affect it's overall design.
>
>
> This addresses bug FLUME-1502.
> https://issues.apache.org/jira/browse/FLUME-1502
>
>
> Diffs
> -----
>
> flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java 5d56599
> flume-ng-core/src/main/java/org/apache/flume/sink/SinkProcessorFactory.java f39b919
> flume-ng-dist/pom.xml d929c88
> flume-ng-doc/sphinx/FlumeDeveloperGuide.rst f52970b
> flume-ng-embedded-agent/pom.xml PRE-CREATION
> flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/EmbeddedAgent.java PRE-CREATION
> flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/EmbeddedAgentConfiguration.java PRE-CREATION
> flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/EmbeddedSource.java PRE-CREATION
> flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/MaterializedConfigurationProvider.java PRE-CREATION
> flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/MemoryConfigurationProvider.java PRE-CREATION
> flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/package-info.java PRE-CREATION
> flume-ng-embedded-agent/src/test/java/org/apache/flume/agent/embedded/TestEmbeddedAgent.java PRE-CREATION
> flume-ng-embedded-agent/src/test/java/org/apache/flume/agent/embedded/TestEmbeddedAgentConfiguration.java PRE-CREATION
> flume-ng-embedded-agent/src/test/java/org/apache/flume/agent/embedded/TestEmbeddedAgentEmbeddedSource.java PRE-CREATION
> flume-ng-embedded-agent/src/test/java/org/apache/flume/agent/embedded/TestEmbeddedAgentState.java PRE-CREATION
> flume-ng-embedded-agent/src/test/resources/log4j.properties PRE-CREATION
> flume-ng-node/src/main/java/org/apache/flume/node/MaterializedConfiguration.java 674fb38
> pom.xml 53ac96b
>
> Diff: https://reviews.apache.org/r/8127/diff/
>
>
> Testing
> -------
>
> Additional unit tests have been added and they pass.
>
>
> Thanks,
>
> Brock Noland
>
>
Re: Review Request: FLUME-1502: Support for running simple configurations
embedded in host process
Posted by Mike Percy <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8127/#review14336
-----------------------------------------------------------
Ship it!
Brock, looks great! I am going to make a minor documentation typo fix/tweak on commit.
- Mike Percy
On Dec. 11, 2012, 9:07 p.m., Brock Noland wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8127/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2012, 9:07 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Patch is on top of the FLUME-1502 branch which has 1630 committed to it.
>
> This patch creates a module flume-ng-embedded-agent which implements FLUME-1502. The patch is not read for commit. Specifically, it needs the following:
>
> 1) whitespace removal
> 2) docs in package-info.java and the developer guide
>
> However, I'd like to start soliciting feedback as these are not items which will affect it's overall design.
>
>
> This addresses bug FLUME-1502.
> https://issues.apache.org/jira/browse/FLUME-1502
>
>
> Diffs
> -----
>
> flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java 526ce59
> flume-ng-core/src/main/java/org/apache/flume/sink/SinkProcessorFactory.java f39b919
> flume-ng-dist/pom.xml d929c88
> flume-ng-doc/sphinx/FlumeDeveloperGuide.rst f52970b
> flume-ng-embedded-agent/pom.xml PRE-CREATION
> flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/EmbeddedAgent.java PRE-CREATION
> flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/EmbeddedAgentConfiguration.java PRE-CREATION
> flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/EmbeddedSource.java PRE-CREATION
> flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/MaterializedConfigurationProvider.java PRE-CREATION
> flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/MemoryConfigurationProvider.java PRE-CREATION
> flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/package-info.java PRE-CREATION
> flume-ng-embedded-agent/src/test/java/org/apache/flume/agent/embedded/TestEmbeddedAgent.java PRE-CREATION
> flume-ng-embedded-agent/src/test/java/org/apache/flume/agent/embedded/TestEmbeddedAgentConfiguration.java PRE-CREATION
> flume-ng-embedded-agent/src/test/java/org/apache/flume/agent/embedded/TestEmbeddedAgentEmbeddedSource.java PRE-CREATION
> flume-ng-embedded-agent/src/test/java/org/apache/flume/agent/embedded/TestEmbeddedAgentState.java PRE-CREATION
> flume-ng-embedded-agent/src/test/resources/log4j.properties PRE-CREATION
> flume-ng-node/src/main/java/org/apache/flume/node/MaterializedConfiguration.java 674fb38
> pom.xml 53ac96b
>
> Diff: https://reviews.apache.org/r/8127/diff/
>
>
> Testing
> -------
>
> Additional unit tests have been added and they pass.
>
>
> Thanks,
>
> Brock Noland
>
>
Re: Review Request: FLUME-1502: Support for running simple configurations
embedded in host process
Posted by Mike Percy <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8127/#review14338
-----------------------------------------------------------
One minor suggestion: When you have a spare minute or two, would you mind updating the spec attached to the JIRA to reflect the latest changes? I think that just means removing AvroSource from the "supported" list.
- Mike Percy
On Dec. 11, 2012, 9:07 p.m., Brock Noland wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8127/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2012, 9:07 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Patch is on top of the FLUME-1502 branch which has 1630 committed to it.
>
> This patch creates a module flume-ng-embedded-agent which implements FLUME-1502. The patch is not read for commit. Specifically, it needs the following:
>
> 1) whitespace removal
> 2) docs in package-info.java and the developer guide
>
> However, I'd like to start soliciting feedback as these are not items which will affect it's overall design.
>
>
> This addresses bug FLUME-1502.
> https://issues.apache.org/jira/browse/FLUME-1502
>
>
> Diffs
> -----
>
> flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java 526ce59
> flume-ng-core/src/main/java/org/apache/flume/sink/SinkProcessorFactory.java f39b919
> flume-ng-dist/pom.xml d929c88
> flume-ng-doc/sphinx/FlumeDeveloperGuide.rst f52970b
> flume-ng-embedded-agent/pom.xml PRE-CREATION
> flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/EmbeddedAgent.java PRE-CREATION
> flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/EmbeddedAgentConfiguration.java PRE-CREATION
> flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/EmbeddedSource.java PRE-CREATION
> flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/MaterializedConfigurationProvider.java PRE-CREATION
> flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/MemoryConfigurationProvider.java PRE-CREATION
> flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/package-info.java PRE-CREATION
> flume-ng-embedded-agent/src/test/java/org/apache/flume/agent/embedded/TestEmbeddedAgent.java PRE-CREATION
> flume-ng-embedded-agent/src/test/java/org/apache/flume/agent/embedded/TestEmbeddedAgentConfiguration.java PRE-CREATION
> flume-ng-embedded-agent/src/test/java/org/apache/flume/agent/embedded/TestEmbeddedAgentEmbeddedSource.java PRE-CREATION
> flume-ng-embedded-agent/src/test/java/org/apache/flume/agent/embedded/TestEmbeddedAgentState.java PRE-CREATION
> flume-ng-embedded-agent/src/test/resources/log4j.properties PRE-CREATION
> flume-ng-node/src/main/java/org/apache/flume/node/MaterializedConfiguration.java 674fb38
> pom.xml 53ac96b
>
> Diff: https://reviews.apache.org/r/8127/diff/
>
>
> Testing
> -------
>
> Additional unit tests have been added and they pass.
>
>
> Thanks,
>
> Brock Noland
>
>
Re: Review Request: FLUME-1502: Support for running simple configurations
embedded in host process
Posted by Brock Noland <br...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8127/
-----------------------------------------------------------
(Updated Dec. 11, 2012, 9:07 p.m.)
Review request for Flume.
Changes
-------
Update patch without failing test.
Description
-------
Patch is on top of the FLUME-1502 branch which has 1630 committed to it.
This patch creates a module flume-ng-embedded-agent which implements FLUME-1502. The patch is not read for commit. Specifically, it needs the following:
1) whitespace removal
2) docs in package-info.java and the developer guide
However, I'd like to start soliciting feedback as these are not items which will affect it's overall design.
This addresses bug FLUME-1502.
https://issues.apache.org/jira/browse/FLUME-1502
Diffs (updated)
-----
flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java 526ce59
flume-ng-core/src/main/java/org/apache/flume/sink/SinkProcessorFactory.java f39b919
flume-ng-dist/pom.xml d929c88
flume-ng-doc/sphinx/FlumeDeveloperGuide.rst f52970b
flume-ng-embedded-agent/pom.xml PRE-CREATION
flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/EmbeddedAgent.java PRE-CREATION
flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/EmbeddedAgentConfiguration.java PRE-CREATION
flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/EmbeddedSource.java PRE-CREATION
flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/MaterializedConfigurationProvider.java PRE-CREATION
flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/MemoryConfigurationProvider.java PRE-CREATION
flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/package-info.java PRE-CREATION
flume-ng-embedded-agent/src/test/java/org/apache/flume/agent/embedded/TestEmbeddedAgent.java PRE-CREATION
flume-ng-embedded-agent/src/test/java/org/apache/flume/agent/embedded/TestEmbeddedAgentConfiguration.java PRE-CREATION
flume-ng-embedded-agent/src/test/java/org/apache/flume/agent/embedded/TestEmbeddedAgentEmbeddedSource.java PRE-CREATION
flume-ng-embedded-agent/src/test/java/org/apache/flume/agent/embedded/TestEmbeddedAgentState.java PRE-CREATION
flume-ng-embedded-agent/src/test/resources/log4j.properties PRE-CREATION
flume-ng-node/src/main/java/org/apache/flume/node/MaterializedConfiguration.java 674fb38
pom.xml 53ac96b
Diff: https://reviews.apache.org/r/8127/diff/
Testing
-------
Additional unit tests have been added and they pass.
Thanks,
Brock Noland
Re: Review Request: FLUME-1502: Support for running simple configurations
embedded in host process
Posted by Brock Noland <br...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8127/
-----------------------------------------------------------
(Updated Dec. 10, 2012, 8:36 p.m.)
Review request for Flume.
Changes
-------
Update patch based on review. Attempts to resolves all deficiencies noted by the reviewer and myself.
Description
-------
Patch is on top of the FLUME-1502 branch which has 1630 committed to it.
This patch creates a module flume-ng-embedded-agent which implements FLUME-1502. The patch is not read for commit. Specifically, it needs the following:
1) whitespace removal
2) docs in package-info.java and the developer guide
However, I'd like to start soliciting feedback as these are not items which will affect it's overall design.
This addresses bug FLUME-1502.
https://issues.apache.org/jira/browse/FLUME-1502
Diffs (updated)
-----
flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java 5d56599
flume-ng-core/src/main/java/org/apache/flume/sink/SinkProcessorFactory.java f39b919
flume-ng-dist/pom.xml d929c88
flume-ng-doc/sphinx/FlumeDeveloperGuide.rst f52970b
flume-ng-embedded-agent/pom.xml PRE-CREATION
flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/EmbeddedAgent.java PRE-CREATION
flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/EmbeddedAgentConfiguration.java PRE-CREATION
flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/EmbeddedSource.java PRE-CREATION
flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/MaterializedConfigurationProvider.java PRE-CREATION
flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/MemoryConfigurationProvider.java PRE-CREATION
flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/package-info.java PRE-CREATION
flume-ng-embedded-agent/src/test/java/org/apache/flume/agent/embedded/TestEmbeddedAgent.java PRE-CREATION
flume-ng-embedded-agent/src/test/java/org/apache/flume/agent/embedded/TestEmbeddedAgentConfiguration.java PRE-CREATION
flume-ng-embedded-agent/src/test/java/org/apache/flume/agent/embedded/TestEmbeddedAgentEmbeddedSource.java PRE-CREATION
flume-ng-embedded-agent/src/test/java/org/apache/flume/agent/embedded/TestEmbeddedAgentState.java PRE-CREATION
flume-ng-embedded-agent/src/test/resources/log4j.properties PRE-CREATION
flume-ng-node/src/main/java/org/apache/flume/node/MaterializedConfiguration.java 674fb38
pom.xml 53ac96b
Diff: https://reviews.apache.org/r/8127/diff/
Testing
-------
Additional unit tests have been added and they pass.
Thanks,
Brock Noland
Re: Review Request: FLUME-1502: Support for running simple configurations
embedded in host process
Posted by Mike Percy <mp...@apache.org>.
> On Dec. 9, 2012, 12:24 a.m., Mike Percy wrote:
> > Brock, looks very nice overall.
> >
> > Some general suggestions:
> > 1. Can we try to add a Javadoc at the top of every interface and class? It helps to specifies its purpose for other devs / reviewers.
> > 2. Does the EmbeddedAgentConfiguration support making the channel "optional" via a channel selector? I can't tell. If not, can we add support for that?
> > 3. Needs a doc section in the Flume developer guide
> >
> > Nit: a few whitespace red things on RB
> >
> > Other specific feedback inline.
> >
>
> Brock Noland wrote:
> Hi Mike,
>
> Thank you for the feedback! Regarding 1, 3, and the whitespace I agree whole heartedly. As I said in in the RB description these are items I plan on addressing in the next iteration. This iteration was to solicit feedback on the approach. Regarding #2, in the design document we specified only a single channel would be allowed. If we allowed that channel to be optional I'd think the user might as well use the RPCClient. What do you think?
>
> I'll address your feedback in the next iteration of the patch! Thanks again!
>
> Brock
>
> Brock Noland wrote:
> Comments address in the latest patch which will be uploaded in a few minutes.
Thanks Brock!
The use case for #2 is that a user of the embedded agent may want to drop events when the channel is full. However, now that I've thought about it some more, they could simply log the resulting EventDeliveryException or ChannelException and continue on without retrying. So unless you can think of a reason why that behavior wouldn't sufficiently satisfy such a use case, this should be fine.
- Mike
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8127/#review14085
-----------------------------------------------------------
On Dec. 10, 2012, 8:36 p.m., Brock Noland wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8127/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2012, 8:36 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Patch is on top of the FLUME-1502 branch which has 1630 committed to it.
>
> This patch creates a module flume-ng-embedded-agent which implements FLUME-1502. The patch is not read for commit. Specifically, it needs the following:
>
> 1) whitespace removal
> 2) docs in package-info.java and the developer guide
>
> However, I'd like to start soliciting feedback as these are not items which will affect it's overall design.
>
>
> This addresses bug FLUME-1502.
> https://issues.apache.org/jira/browse/FLUME-1502
>
>
> Diffs
> -----
>
> flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java 5d56599
> flume-ng-core/src/main/java/org/apache/flume/sink/SinkProcessorFactory.java f39b919
> flume-ng-dist/pom.xml d929c88
> flume-ng-doc/sphinx/FlumeDeveloperGuide.rst f52970b
> flume-ng-embedded-agent/pom.xml PRE-CREATION
> flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/EmbeddedAgent.java PRE-CREATION
> flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/EmbeddedAgentConfiguration.java PRE-CREATION
> flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/EmbeddedSource.java PRE-CREATION
> flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/MaterializedConfigurationProvider.java PRE-CREATION
> flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/MemoryConfigurationProvider.java PRE-CREATION
> flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/package-info.java PRE-CREATION
> flume-ng-embedded-agent/src/test/java/org/apache/flume/agent/embedded/TestEmbeddedAgent.java PRE-CREATION
> flume-ng-embedded-agent/src/test/java/org/apache/flume/agent/embedded/TestEmbeddedAgentConfiguration.java PRE-CREATION
> flume-ng-embedded-agent/src/test/java/org/apache/flume/agent/embedded/TestEmbeddedAgentEmbeddedSource.java PRE-CREATION
> flume-ng-embedded-agent/src/test/java/org/apache/flume/agent/embedded/TestEmbeddedAgentState.java PRE-CREATION
> flume-ng-embedded-agent/src/test/resources/log4j.properties PRE-CREATION
> flume-ng-node/src/main/java/org/apache/flume/node/MaterializedConfiguration.java 674fb38
> pom.xml 53ac96b
>
> Diff: https://reviews.apache.org/r/8127/diff/
>
>
> Testing
> -------
>
> Additional unit tests have been added and they pass.
>
>
> Thanks,
>
> Brock Noland
>
>
Re: Review Request: FLUME-1502: Support for running simple configurations
embedded in host process
Posted by Brock Noland <br...@cloudera.com>.
> On Dec. 9, 2012, 12:24 a.m., Mike Percy wrote:
> > Brock, looks very nice overall.
> >
> > Some general suggestions:
> > 1. Can we try to add a Javadoc at the top of every interface and class? It helps to specifies its purpose for other devs / reviewers.
> > 2. Does the EmbeddedAgentConfiguration support making the channel "optional" via a channel selector? I can't tell. If not, can we add support for that?
> > 3. Needs a doc section in the Flume developer guide
> >
> > Nit: a few whitespace red things on RB
> >
> > Other specific feedback inline.
> >
>
> Brock Noland wrote:
> Hi Mike,
>
> Thank you for the feedback! Regarding 1, 3, and the whitespace I agree whole heartedly. As I said in in the RB description these are items I plan on addressing in the next iteration. This iteration was to solicit feedback on the approach. Regarding #2, in the design document we specified only a single channel would be allowed. If we allowed that channel to be optional I'd think the user might as well use the RPCClient. What do you think?
>
> I'll address your feedback in the next iteration of the patch! Thanks again!
>
> Brock
>
> Brock Noland wrote:
> Comments address in the latest patch which will be uploaded in a few minutes.
>
> Mike Percy wrote:
> Thanks Brock!
>
> The use case for #2 is that a user of the embedded agent may want to drop events when the channel is full. However, now that I've thought about it some more, they could simply log the resulting EventDeliveryException or ChannelException and continue on without retrying. So unless you can think of a reason why that behavior wouldn't sufficiently satisfy such a use case, this should be fine.
OK, yeah Yeah I think if they were going to want to drop events they can log the EventDeliveryException.
- Brock
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8127/#review14085
-----------------------------------------------------------
On Dec. 10, 2012, 8:36 p.m., Brock Noland wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8127/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2012, 8:36 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Patch is on top of the FLUME-1502 branch which has 1630 committed to it.
>
> This patch creates a module flume-ng-embedded-agent which implements FLUME-1502. The patch is not read for commit. Specifically, it needs the following:
>
> 1) whitespace removal
> 2) docs in package-info.java and the developer guide
>
> However, I'd like to start soliciting feedback as these are not items which will affect it's overall design.
>
>
> This addresses bug FLUME-1502.
> https://issues.apache.org/jira/browse/FLUME-1502
>
>
> Diffs
> -----
>
> flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java 5d56599
> flume-ng-core/src/main/java/org/apache/flume/sink/SinkProcessorFactory.java f39b919
> flume-ng-dist/pom.xml d929c88
> flume-ng-doc/sphinx/FlumeDeveloperGuide.rst f52970b
> flume-ng-embedded-agent/pom.xml PRE-CREATION
> flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/EmbeddedAgent.java PRE-CREATION
> flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/EmbeddedAgentConfiguration.java PRE-CREATION
> flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/EmbeddedSource.java PRE-CREATION
> flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/MaterializedConfigurationProvider.java PRE-CREATION
> flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/MemoryConfigurationProvider.java PRE-CREATION
> flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/package-info.java PRE-CREATION
> flume-ng-embedded-agent/src/test/java/org/apache/flume/agent/embedded/TestEmbeddedAgent.java PRE-CREATION
> flume-ng-embedded-agent/src/test/java/org/apache/flume/agent/embedded/TestEmbeddedAgentConfiguration.java PRE-CREATION
> flume-ng-embedded-agent/src/test/java/org/apache/flume/agent/embedded/TestEmbeddedAgentEmbeddedSource.java PRE-CREATION
> flume-ng-embedded-agent/src/test/java/org/apache/flume/agent/embedded/TestEmbeddedAgentState.java PRE-CREATION
> flume-ng-embedded-agent/src/test/resources/log4j.properties PRE-CREATION
> flume-ng-node/src/main/java/org/apache/flume/node/MaterializedConfiguration.java 674fb38
> pom.xml 53ac96b
>
> Diff: https://reviews.apache.org/r/8127/diff/
>
>
> Testing
> -------
>
> Additional unit tests have been added and they pass.
>
>
> Thanks,
>
> Brock Noland
>
>
Re: Review Request: FLUME-1502: Support for running simple configurations
embedded in host process
Posted by Brock Noland <br...@cloudera.com>.
> On Dec. 9, 2012, 12:24 a.m., Mike Percy wrote:
> > flume-ng-core/src/main/java/org/apache/flume/source/AvroSource.java, line 242
> > <https://reviews.apache.org/r/8127/diff/1/?file=221801#file221801line242>
> >
> > Why add these public methods to AvroSource?
This is to support the put, putAll methods on the embedded agent. We've decided against allowing AvroSource so this can be removed.
> On Dec. 9, 2012, 12:24 a.m., Mike Percy wrote:
> > flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/EmbeddedAgent.java, line 75
> > <https://reviews.apache.org/r/8127/diff/1/?file=221805#file221805line75>
> >
> > Should we add
> >
> > @InterfaceAudience.Public
> > @InterfaceStability.Stable
> >
> > to this constructor?
The class is marked Public and Stable as such that applies to all methods unless specified otherwise.
- Brock
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8127/#review14085
-----------------------------------------------------------
On Nov. 19, 2012, 7:42 p.m., Brock Noland wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8127/
> -----------------------------------------------------------
>
> (Updated Nov. 19, 2012, 7:42 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Patch is on top of the FLUME-1502 branch which has 1630 committed to it.
>
> This patch creates a module flume-ng-embedded-agent which implements FLUME-1502. The patch is not read for commit. Specifically, it needs the following:
>
> 1) whitespace removal
> 2) docs in package-info.java and the developer guide
>
> However, I'd like to start soliciting feedback as these are not items which will affect it's overall design.
>
>
> This addresses bug FLUME-1502.
> https://issues.apache.org/jira/browse/FLUME-1502
>
>
> Diffs
> -----
>
> flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java 9b209e8
> flume-ng-core/src/main/java/org/apache/flume/sink/SinkProcessorFactory.java f39b919
> flume-ng-core/src/main/java/org/apache/flume/source/AvroSource.java 47ccf9f
> flume-ng-dist/pom.xml d929c88
> flume-ng-embedded-agent/pom.xml PRE-CREATION
> flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/AvroLocalSource.java PRE-CREATION
> flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/EmbeddedAgent.java PRE-CREATION
> flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/EmbeddedAgentConfiguration.java PRE-CREATION
> flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/EmbeddedSource.java PRE-CREATION
> flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/LocalSource.java PRE-CREATION
> flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/MaterializedConfigurationProvider.java PRE-CREATION
> flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/MemoryConfigurationProvider.java PRE-CREATION
> flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/package-info.java PRE-CREATION
> flume-ng-embedded-agent/src/test/java/org/apache/flume/agent/embedded/TestEmbeddedAgentAvroSource.java PRE-CREATION
> flume-ng-embedded-agent/src/test/java/org/apache/flume/agent/embedded/TestEmbeddedAgentConfiguration.java PRE-CREATION
> flume-ng-embedded-agent/src/test/java/org/apache/flume/agent/embedded/TestEmbeddedAgentEmbeddedSource.java PRE-CREATION
> flume-ng-embedded-agent/src/test/java/org/apache/flume/agent/embedded/TestEmbeddedAgentState.java PRE-CREATION
> flume-ng-embedded-agent/src/test/resources/log4j.properties PRE-CREATION
> pom.xml 76b8351
>
> Diff: https://reviews.apache.org/r/8127/diff/
>
>
> Testing
> -------
>
> Additional unit tests have been added and they pass.
>
>
> Thanks,
>
> Brock Noland
>
>
Re: Review Request: FLUME-1502: Support for running simple configurations
embedded in host process
Posted by Brock Noland <br...@cloudera.com>.
> On Dec. 9, 2012, 12:24 a.m., Mike Percy wrote:
> > Brock, looks very nice overall.
> >
> > Some general suggestions:
> > 1. Can we try to add a Javadoc at the top of every interface and class? It helps to specifies its purpose for other devs / reviewers.
> > 2. Does the EmbeddedAgentConfiguration support making the channel "optional" via a channel selector? I can't tell. If not, can we add support for that?
> > 3. Needs a doc section in the Flume developer guide
> >
> > Nit: a few whitespace red things on RB
> >
> > Other specific feedback inline.
> >
>
> Brock Noland wrote:
> Hi Mike,
>
> Thank you for the feedback! Regarding 1, 3, and the whitespace I agree whole heartedly. As I said in in the RB description these are items I plan on addressing in the next iteration. This iteration was to solicit feedback on the approach. Regarding #2, in the design document we specified only a single channel would be allowed. If we allowed that channel to be optional I'd think the user might as well use the RPCClient. What do you think?
>
> I'll address your feedback in the next iteration of the patch! Thanks again!
>
> Brock
Comments address in the latest patch which will be uploaded in a few minutes.
- Brock
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8127/#review14085
-----------------------------------------------------------
On Nov. 19, 2012, 7:42 p.m., Brock Noland wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8127/
> -----------------------------------------------------------
>
> (Updated Nov. 19, 2012, 7:42 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Patch is on top of the FLUME-1502 branch which has 1630 committed to it.
>
> This patch creates a module flume-ng-embedded-agent which implements FLUME-1502. The patch is not read for commit. Specifically, it needs the following:
>
> 1) whitespace removal
> 2) docs in package-info.java and the developer guide
>
> However, I'd like to start soliciting feedback as these are not items which will affect it's overall design.
>
>
> This addresses bug FLUME-1502.
> https://issues.apache.org/jira/browse/FLUME-1502
>
>
> Diffs
> -----
>
> flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java 9b209e8
> flume-ng-core/src/main/java/org/apache/flume/sink/SinkProcessorFactory.java f39b919
> flume-ng-core/src/main/java/org/apache/flume/source/AvroSource.java 47ccf9f
> flume-ng-dist/pom.xml d929c88
> flume-ng-embedded-agent/pom.xml PRE-CREATION
> flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/AvroLocalSource.java PRE-CREATION
> flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/EmbeddedAgent.java PRE-CREATION
> flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/EmbeddedAgentConfiguration.java PRE-CREATION
> flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/EmbeddedSource.java PRE-CREATION
> flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/LocalSource.java PRE-CREATION
> flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/MaterializedConfigurationProvider.java PRE-CREATION
> flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/MemoryConfigurationProvider.java PRE-CREATION
> flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/package-info.java PRE-CREATION
> flume-ng-embedded-agent/src/test/java/org/apache/flume/agent/embedded/TestEmbeddedAgentAvroSource.java PRE-CREATION
> flume-ng-embedded-agent/src/test/java/org/apache/flume/agent/embedded/TestEmbeddedAgentConfiguration.java PRE-CREATION
> flume-ng-embedded-agent/src/test/java/org/apache/flume/agent/embedded/TestEmbeddedAgentEmbeddedSource.java PRE-CREATION
> flume-ng-embedded-agent/src/test/java/org/apache/flume/agent/embedded/TestEmbeddedAgentState.java PRE-CREATION
> flume-ng-embedded-agent/src/test/resources/log4j.properties PRE-CREATION
> pom.xml 76b8351
>
> Diff: https://reviews.apache.org/r/8127/diff/
>
>
> Testing
> -------
>
> Additional unit tests have been added and they pass.
>
>
> Thanks,
>
> Brock Noland
>
>
Re: Review Request: FLUME-1502: Support for running simple configurations
embedded in host process
Posted by Brock Noland <br...@cloudera.com>.
> On Dec. 9, 2012, 12:24 a.m., Mike Percy wrote:
> > Brock, looks very nice overall.
> >
> > Some general suggestions:
> > 1. Can we try to add a Javadoc at the top of every interface and class? It helps to specifies its purpose for other devs / reviewers.
> > 2. Does the EmbeddedAgentConfiguration support making the channel "optional" via a channel selector? I can't tell. If not, can we add support for that?
> > 3. Needs a doc section in the Flume developer guide
> >
> > Nit: a few whitespace red things on RB
> >
> > Other specific feedback inline.
> >
Hi Mike,
Thank you for the feedback! Regarding 1, 3, and the whitespace I agree whole heartedly. As I said in in the RB description these are items I plan on addressing in the next iteration. This iteration was to solicit feedback on the approach. Regarding #2, in the design document we specified only a single channel would be allowed. If we allowed that channel to be optional I'd think the user might as well use the RPCClient. What do you think?
I'll address your feedback in the next iteration of the patch! Thanks again!
Brock
- Brock
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8127/#review14085
-----------------------------------------------------------
On Nov. 19, 2012, 7:42 p.m., Brock Noland wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8127/
> -----------------------------------------------------------
>
> (Updated Nov. 19, 2012, 7:42 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Patch is on top of the FLUME-1502 branch which has 1630 committed to it.
>
> This patch creates a module flume-ng-embedded-agent which implements FLUME-1502. The patch is not read for commit. Specifically, it needs the following:
>
> 1) whitespace removal
> 2) docs in package-info.java and the developer guide
>
> However, I'd like to start soliciting feedback as these are not items which will affect it's overall design.
>
>
> This addresses bug FLUME-1502.
> https://issues.apache.org/jira/browse/FLUME-1502
>
>
> Diffs
> -----
>
> flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java 9b209e8
> flume-ng-core/src/main/java/org/apache/flume/sink/SinkProcessorFactory.java f39b919
> flume-ng-core/src/main/java/org/apache/flume/source/AvroSource.java 47ccf9f
> flume-ng-dist/pom.xml d929c88
> flume-ng-embedded-agent/pom.xml PRE-CREATION
> flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/AvroLocalSource.java PRE-CREATION
> flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/EmbeddedAgent.java PRE-CREATION
> flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/EmbeddedAgentConfiguration.java PRE-CREATION
> flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/EmbeddedSource.java PRE-CREATION
> flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/LocalSource.java PRE-CREATION
> flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/MaterializedConfigurationProvider.java PRE-CREATION
> flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/MemoryConfigurationProvider.java PRE-CREATION
> flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/package-info.java PRE-CREATION
> flume-ng-embedded-agent/src/test/java/org/apache/flume/agent/embedded/TestEmbeddedAgentAvroSource.java PRE-CREATION
> flume-ng-embedded-agent/src/test/java/org/apache/flume/agent/embedded/TestEmbeddedAgentConfiguration.java PRE-CREATION
> flume-ng-embedded-agent/src/test/java/org/apache/flume/agent/embedded/TestEmbeddedAgentEmbeddedSource.java PRE-CREATION
> flume-ng-embedded-agent/src/test/java/org/apache/flume/agent/embedded/TestEmbeddedAgentState.java PRE-CREATION
> flume-ng-embedded-agent/src/test/resources/log4j.properties PRE-CREATION
> pom.xml 76b8351
>
> Diff: https://reviews.apache.org/r/8127/diff/
>
>
> Testing
> -------
>
> Additional unit tests have been added and they pass.
>
>
> Thanks,
>
> Brock Noland
>
>
Re: Review Request: FLUME-1502: Support for running simple configurations
embedded in host process
Posted by Mike Percy <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8127/#review14085
-----------------------------------------------------------
Brock, looks very nice overall.
Some general suggestions:
1. Can we try to add a Javadoc at the top of every interface and class? It helps to specifies its purpose for other devs / reviewers.
2. Does the EmbeddedAgentConfiguration support making the channel "optional" via a channel selector? I can't tell. If not, can we add support for that?
3. Needs a doc section in the Flume developer guide
Nit: a few whitespace red things on RB
Other specific feedback inline.
flume-ng-core/src/main/java/org/apache/flume/source/AvroSource.java
<https://reviews.apache.org/r/8127/#comment30140>
Why add these public methods to AvroSource?
flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/EmbeddedAgent.java
<https://reviews.apache.org/r/8127/#comment30286>
Should we add
@InterfaceAudience.Public
@InterfaceStability.Stable
to this constructor?
flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/EmbeddedAgent.java
<https://reviews.apache.org/r/8127/#comment30341>
Let's consider only allowing the LocalSource.
flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/EmbeddedAgent.java
<https://reviews.apache.org/r/8127/#comment30340>
Should be "Expected one sink group", not one sink, right?
flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/EmbeddedAgentConfiguration.java
<https://reviews.apache.org/r/8127/#comment30345>
Can we split this up into validate() and configure() or something... this method does more than simply validate the config.
flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/MaterializedConfigurationProvider.java
<https://reviews.apache.org/r/8127/#comment30346>
What does "Materialized" mean? Would be nice to explain the terminology since I find it confusing, or rename the class maybe :)
flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/package-info.java
<https://reviews.apache.org/r/8127/#comment30347>
Needs an Apache license header
- Mike Percy
On Nov. 19, 2012, 7:42 p.m., Brock Noland wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8127/
> -----------------------------------------------------------
>
> (Updated Nov. 19, 2012, 7:42 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Patch is on top of the FLUME-1502 branch which has 1630 committed to it.
>
> This patch creates a module flume-ng-embedded-agent which implements FLUME-1502. The patch is not read for commit. Specifically, it needs the following:
>
> 1) whitespace removal
> 2) docs in package-info.java and the developer guide
>
> However, I'd like to start soliciting feedback as these are not items which will affect it's overall design.
>
>
> This addresses bug FLUME-1502.
> https://issues.apache.org/jira/browse/FLUME-1502
>
>
> Diffs
> -----
>
> flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java 9b209e8
> flume-ng-core/src/main/java/org/apache/flume/sink/SinkProcessorFactory.java f39b919
> flume-ng-core/src/main/java/org/apache/flume/source/AvroSource.java 47ccf9f
> flume-ng-dist/pom.xml d929c88
> flume-ng-embedded-agent/pom.xml PRE-CREATION
> flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/AvroLocalSource.java PRE-CREATION
> flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/EmbeddedAgent.java PRE-CREATION
> flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/EmbeddedAgentConfiguration.java PRE-CREATION
> flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/EmbeddedSource.java PRE-CREATION
> flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/LocalSource.java PRE-CREATION
> flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/MaterializedConfigurationProvider.java PRE-CREATION
> flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/MemoryConfigurationProvider.java PRE-CREATION
> flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/package-info.java PRE-CREATION
> flume-ng-embedded-agent/src/test/java/org/apache/flume/agent/embedded/TestEmbeddedAgentAvroSource.java PRE-CREATION
> flume-ng-embedded-agent/src/test/java/org/apache/flume/agent/embedded/TestEmbeddedAgentConfiguration.java PRE-CREATION
> flume-ng-embedded-agent/src/test/java/org/apache/flume/agent/embedded/TestEmbeddedAgentEmbeddedSource.java PRE-CREATION
> flume-ng-embedded-agent/src/test/java/org/apache/flume/agent/embedded/TestEmbeddedAgentState.java PRE-CREATION
> flume-ng-embedded-agent/src/test/resources/log4j.properties PRE-CREATION
> pom.xml 76b8351
>
> Diff: https://reviews.apache.org/r/8127/diff/
>
>
> Testing
> -------
>
> Additional unit tests have been added and they pass.
>
>
> Thanks,
>
> Brock Noland
>
>