[GitHub] [geode] PurelyApplied opened pull request #2895: GEODE-6091: Pass same environment to main CI as to pull-requests.

["PurelyApplied (GitHub)" <gi...@apache.org>]

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/2895 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] rhoughton-pivot commented on issue #2895: GEODE-6091: Pass same environment to main CI as to pull-requests.

["rhoughton-pivot (GitHub)" <gi...@apache.org>]

Merged early, because this was a CI only change, and PR pipeline uses CI files from develop, not the incoming changes.

[ Full content available at: https://github.com/apache/geode/pull/2895 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] PurelyApplied commented on issue #2895: GEODE-6091: Pass same environment to main CI as to pull-requests.

["PurelyApplied (GitHub)" <gi...@apache.org>]

This environment variable is used to determine the image family name in the `create_instance.sh`.  The mismatch has resulted in us using the old version of the images, most recent change on Oct 10.

This is almost certain to cause the main pipeline to (correctly) fail with the `SizingFlagDUnitTest > testPRHeapLRUDeltaPutOnPrimary` failure we have been seeing in the pull-request pipeline.

[ Full content available at: https://github.com/apache/geode/pull/2895 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] rhoughton-pivot commented on pull request #2895: GEODE-6091: Pass same environment to main CI as to pull-requests.

["rhoughton-pivot (GitHub)" <gi...@apache.org>]

`create_instance.sh` should not need UPSTREAM_FORK. Instead, remove the conditional inside of `create_instance.sh` to always an image-family-prefix variable.

[ Full content available at: https://github.com/apache/geode/pull/2895 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] rhoughton-pivot closed pull request #2895: GEODE-6091: Pass same environment to main CI as to pull-requests.

["rhoughton-pivot (GitHub)" <gi...@apache.org>]

[ pull request closed by rhoughton-pivot ]

[ Full content available at: https://github.com/apache/geode/pull/2895 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org