[GitHub] [rocketmq-schema-registry] ferrirW commented on a diff in pull request #25: refine avro serde type to SpecificAvroSerde and GernericAvroSerde

[GitBox <gi...@apache.org>]

ferrirW commented on code in PR #25:
URL: https://github.com/apache/rocketmq-schema-registry/pull/25#discussion_r936183073


##########
example/src/main/java/org/apache/rocketmq/schema/registry/example/serde/SpecificAvroSerdeDemo.java:
##########
@@ -19,26 +19,28 @@
 
 import org.apache.rocketmq.schema.registry.client.SchemaRegistryClient;
 import org.apache.rocketmq.schema.registry.client.SchemaRegistryClientFactory;
-import org.apache.rocketmq.schema.registry.client.serializer.AvroDeserializer;
-import org.apache.rocketmq.schema.registry.client.serializer.AvroSerializer;
-import org.apache.rocketmq.schema.registry.client.serializer.Deserializer;
-import org.apache.rocketmq.schema.registry.client.serializer.Serializer;
+import org.apache.rocketmq.schema.registry.client.serde.SpecificAvroSerde;
 
-public class AvroSerdeDemo {
+import java.io.IOException;
+
+public class SpecificAvroSerdeDemo {
 
     public static void main(String[] args) {
 
         String baseUrl = "http://localhost:8080/schema-registry/v1";

Review Comment:
   Instead, mock a SchemaRegistry in a unit test.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org