You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "ahmedabu98 (via GitHub)" <gi...@apache.org> on 2023/05/04 19:26:47 UTC
[GitHub] [beam] ahmedabu98 commented on a diff in pull request #26559: Add batch storage write api test addressing recent dataloss case #26503
ahmedabu98 commented on code in PR #26559:
URL: https://github.com/apache/beam/pull/26559#discussion_r1185429757
##########
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIOWriteTest.java:
##########
@@ -180,6 +180,7 @@ public static Iterable<Object[]> data() {
new Object[] {false, false, false},
new Object[] {false, false, true},
new Object[] {true, false, false},
+ new Object[] {true, true, false},
Review Comment:
I noticed storage write at least once mode for batch wasn't included in these tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org