You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Ke Jia <ke...@intel.com> on 2018/01/19 05:34:01 UTC
Re: Review Request 55156: Min-max runtime filtering

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55156/#review195780
-----------------------------------------------------------




ql/src/java/org/apache/hadoop/hive/ql/exec/tez/DynamicValueRegistryTez.java
Lines 121 (patched)
<https://reviews.apache.org/r/55156/#comment275086>

    hi Jaiswal, here why we need to evaluate the min/max/bloom filter expression again? Whether the row stand for the min/max/bloom filter value after (GBY->RS)operator or not?


- Ke Jia


On Jan. 22, 2017, 10:11 p.m., Deepak Jaiswal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55156/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2017, 10:11 p.m.)
> 
> 
> Review request for hive, Gopal V, Gunther Hagleitner, Jason Dere, Prasanth_J, and Rajesh Balamohan.
> 
> 
> Bugs: HIVE-15269
>     https://issues.apache.org/jira/browse/HIVE-15269
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-15269 min-max runtime filtering.
> The patch also contains the patch for HIVE-15270.
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1dbae40 
>   itests/src/test/resources/testconfiguration.properties 792de2e 
>   orc/src/test/org/apache/orc/impl/TestRecordReaderImpl.java cdd62ac 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/AbstractMapJoinOperator.java 69ba4a2 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/CommonJoinOperator.java 7e9007c 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/DynamicValueRegistry.java PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeColumnEvaluator.java 24c8281 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeConstantDefaultEvaluator.java 89a75eb 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeConstantEvaluator.java 4fe72a0 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeDynamicValueEvaluator.java PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeEvaluator.java b8d6ab7 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeEvaluatorFactory.java 0d03d8f 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeEvaluatorHead.java 42685fb 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeEvaluatorRef.java 0a6b66a 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeFieldEvaluator.java ff32626 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeGenericFuncEvaluator.java 221abd9 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/FilterOperator.java bd0d28c 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 4fce1ac 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/GroupByOperator.java 46f0ecd 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/HashTableSinkOperator.java ac5331e 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/JoinUtil.java 9718c48 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/ObjectCache.java 440e0a1 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/ObjectCacheWrapper.java 9768efa 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/SelectOperator.java 9049ddd 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ObjectCache.java 008f8a4 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/DynamicValueRegistryTez.java PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/LlapObjectCache.java 0141230 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/MapRecordProcessor.java 955fa80 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/ObjectCache.java 06dca00 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/ReduceRecordProcessor.java d80f201 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorMapJoinOperator.java 0cb6c8a 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorSMBMapJoinOperator.java 80b0a14 
>   ql/src/java/org/apache/hadoop/hive/ql/io/sarg/ConvertAstToSearchArg.java 9d900e4 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/DynamicPartitionPruningOptimization.java 26fcc45 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/FixedBucketPruningOptimizer.java 9e9beb0 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/RedundantDynamicPruningConditionsRemoval.java d9ce017 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java aa1e509 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/GenTezUtils.java 3a111aa 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/ParseContext.java 35f34da 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/RuntimeValuesInfo.java PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/TaskCompiler.java e8b003e 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/TezCompiler.java cdb9e1b 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/AggregationDesc.java 1ecbaad 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/BaseWork.java 13a0811 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/DynamicValue.java PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeDynamicValueDesc.java PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFBloomFilter.java PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFEvaluator.java 18d5285 
>   ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFInBloomFilter.java PRE-CREATION 
>   ql/src/test/org/apache/hadoop/hive/ql/io/sarg/TestConvertAstToSearchArg.java 93b50a6 
>   ql/src/test/org/apache/hadoop/hive/ql/io/sarg/TestSearchArgumentImpl.java 8cbc26d 
>   ql/src/test/org/apache/hadoop/hive/ql/optimizer/physical/TestVectorizer.java 3295372 
>   ql/src/test/queries/clientpositive/dynamic_semijoin_reduction.q PRE-CREATION 
>   ql/src/test/results/clientpositive/llap/dynamic_partition_pruning.q.out c37f3b9 
>   ql/src/test/results/clientpositive/llap/dynamic_semijoin_reduction.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/llap/join32_lessSize.q.out 15eb751 
>   ql/src/test/results/clientpositive/llap/llap_partitioned.q.out 541ece8 
>   ql/src/test/results/clientpositive/llap/mergejoin.q.out 9d27a10 
>   ql/src/test/results/clientpositive/llap/orc_llap.q.out 6b6706e 
>   ql/src/test/results/clientpositive/llap/subquery_scalar.q.out 09b0a83 
>   ql/src/test/results/clientpositive/llap/vectorized_dynamic_partition_pruning.q.out dc1b60f 
>   ql/src/test/results/clientpositive/perf/query16.q.out 1648ddb 
>   ql/src/test/results/clientpositive/perf/query6.q.out 5500e7a 
>   ql/src/test/results/clientpositive/perf/query83.q.out 004dc41 
>   ql/src/test/results/clientpositive/show_functions.q.out 90b86c3 
>   ql/src/test/results/clientpositive/tez/explainanalyze_3.q.out d15c83f 
>   ql/src/test/results/clientpositive/tez/explainuser_3.q.out 2db8b5e 
>   storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/LiteralDelegate.java PRE-CREATION 
>   storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgumentFactory.java 8fda95c 
>   storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgumentImpl.java 10d8c51 
>   storage-api/src/java/org/apache/hive/common/util/BloomFilter.java e60690d 
> 
> 
> Diff: https://reviews.apache.org/r/55156/diff/9/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Deepak Jaiswal
> 
>