You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "sebbASF (via GitHub)" <gi...@apache.org> on 2024/02/13 00:34:51 UTC
[PR] Wrong location for EOL [commons-net]
sebbASF opened a new pull request, #217:
URL: https://github.com/apache/commons-net/pull/217
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Wrong location for EOL [commons-net]
Posted by "thc202 (via GitHub)" <gi...@apache.org>.
thc202 commented on PR #217:
URL: https://github.com/apache/commons-net/pull/217#issuecomment-1941084689
The `CRLF` being added in the other line is still needed though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Wrong location for EOL [commons-net]
Posted by "sebbASF (via GitHub)" <gi...@apache.org>.
sebbASF commented on PR #217:
URL: https://github.com/apache/commons-net/pull/217#issuecomment-1941074836
Good point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Wrong location for EOL [commons-net]
Posted by "sebbASF (via GitHub)" <gi...@apache.org>.
sebbASF commented on PR #217:
URL: https://github.com/apache/commons-net/pull/217#issuecomment-1941106487
> The `CRLF` being added in the other line is still needed though.
Agreed, but that should be a separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Wrong location for EOL [commons-net]
Posted by "thc202 (via GitHub)" <gi...@apache.org>.
thc202 commented on code in PR #217:
URL: https://github.com/apache/commons-net/pull/217#discussion_r1487544841
##########
src/main/java/org/apache/commons/net/ftp/FTPHTTPClient.java:
##########
@@ -194,8 +194,8 @@ private BufferedReader tunnelHandshake(final String host, final int port, final
final String auth = proxyUserName + ":" + proxyPassword;
final String header = "Proxy-Authorization: Basic " + Base64.getEncoder().encodeToString(auth.getBytes(charset));
output.write(header.getBytes(charset));
+ output.write(CRLF);
}
- output.write(CRLF);
Review Comment:
This one should be kept, https://datatracker.ietf.org/doc/html/rfc7230#autoid-15
> an empty line indicating the end of the header section
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Wrong location for EOL [commons-net]
Posted by "sebbASF (via GitHub)" <gi...@apache.org>.
sebbASF closed pull request #217: Wrong location for EOL
URL: https://github.com/apache/commons-net/pull/217
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org