You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Hao Hao (Code Review)" <ge...@cloudera.org> on 2020/10/25 02:19:05 UTC

[kudu-CR] Remove redundant code in TabletReplica

Hao Hao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16647


Change subject: Remove redundant code in TabletReplica
......................................................................

Remove redundant code in TabletReplica

Change-Id: I506d1522ccdbf1bef6df54b19222d9c6b91789b6
---
M src/kudu/tablet/tablet_replica.h
1 file changed, 0 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/47/16647/1
-- 
To view, visit http://gerrit.cloudera.org:8080/16647
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I506d1522ccdbf1bef6df54b19222d9c6b91789b6
Gerrit-Change-Number: 16647
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>

[kudu-CR] Remove redundant code in TabletReplica

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16647 )

Change subject: Remove redundant code in TabletReplica
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/16647
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I506d1522ccdbf1bef6df54b19222d9c6b91789b6
Gerrit-Change-Number: 16647
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 26 Oct 2020 06:09:10 +0000
Gerrit-HasComments: No

[kudu-CR] Remove redundant code in TabletReplica

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16647 )

Change subject: Remove redundant code in TabletReplica
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/16647
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I506d1522ccdbf1bef6df54b19222d9c6b91789b6
Gerrit-Change-Number: 16647
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 26 Oct 2020 13:34:41 +0000
Gerrit-HasComments: No

[kudu-CR] Remove redundant code in TabletReplica

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16647 )

Change subject: Remove redundant code in TabletReplica
......................................................................

Remove redundant code in TabletReplica

Change-Id: I506d1522ccdbf1bef6df54b19222d9c6b91789b6
Reviewed-on: http://gerrit.cloudera.org:8080/16647
Tested-by: Kudu Jenkins
Reviewed-by: Andrew Wong <aw...@cloudera.com>
Reviewed-by: Grant Henke <gr...@apache.org>
---
M src/kudu/tablet/tablet_replica.h
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  Kudu Jenkins: Verified
  Andrew Wong: Looks good to me, approved
  Grant Henke: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/16647
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I506d1522ccdbf1bef6df54b19222d9c6b91789b6
Gerrit-Change-Number: 16647
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)