You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "a140262 (via GitHub)" <gi...@apache.org> on 2023/09/13 05:21:15 UTC
[GitHub] [incubator-celeborn] a140262 opened a new pull request, #1901: [CELEBORN-968]fix helm chart volumeMount name issue
a140262 opened a new pull request, #1901:
URL: https://github.com/apache/incubator-celeborn/pull/1901
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
Update volumeMounts's name by a dynamic {{ $.Release.Name }} prefix in `master-stateful.yaml` and `worker-stateful.yaml`
### Why are the changes needed?
When running multiple Celeborn clusters with different release names and Celeborn versions, helm install was failed until making the initContainers' volume name dynamic. See the error from master's statefulset :
>> kubectl describe statefulset.apps/clbv3-master -n celeborn
Events:
Type Reason Age From Message
---- ------ ---- ---- -------
Warning FailedCreate 5s (x14 over 46s) statefulset-controller create Pod clbv3-master-0 in StatefulSet clbv3-master failed error: Pod "clbv3-master-0" is invalid: spec.initContainers[0].volumeMounts[0].name: Not found: "celeborn-master-vol-0"
### Does this PR introduce _any_ user-facing change?
no
### How was this patch tested?
Helm install Celeborn cluster twice in the same namespace but different release names. It shouldn't fail.
For example:
```
helm install celeborn charts/celeborn-shuffle-service -n celeborn
helm install clbv3 charts/celeborn-shuffle-service -n celeborn
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 closed pull request #1901: [CELEBORN-968] Make volume name dynamic in StatefulSet in Helm chart
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 closed pull request #1901: [CELEBORN-968] Make volume name dynamic in StatefulSet in Helm chart
URL: https://github.com/apache/incubator-celeborn/pull/1901
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1901: [CELEBORN-968] Make volume name dynamic in StatefulSet in Helm chart
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1901:
URL: https://github.com/apache/incubator-celeborn/pull/1901#issuecomment-1716975874
## [Codecov](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1901?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#1901](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1901?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (65c9e66) into [main](https://app.codecov.io/gh/apache/incubator-celeborn/commit/0e53a3d55231967e1bbd8e47ab99906836f4f550?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (0e53a3d) will **increase** coverage by `0.02%`.
> Report is 1 commits behind head on main.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## main #1901 +/- ##
==========================================
+ Coverage 46.50% 46.51% +0.02%
==========================================
Files 164 164
Lines 10222 10228 +6
Branches 936 936
==========================================
+ Hits 4753 4757 +4
- Misses 5156 5157 +1
- Partials 313 314 +1
```
| [Files Changed](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1901?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...cala/org/apache/celeborn/common/CelebornConf.scala](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1901?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vY29tbW9uL0NlbGVib3JuQ29uZi5zY2FsYQ==) | `87.49% <100.00%> (+0.03%)` | :arrow_up: |
... and [1 file with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1901/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 commented on pull request #1901: [CELEBORN-968] Make volume name dynamic in StatefulSet in Helm chart
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #1901:
URL: https://github.com/apache/incubator-celeborn/pull/1901#issuecomment-1716988105
Thanks, merged to main/0.3.
The 0.3.1 is voting, I suppose this is not a critical issue to fail the vote, and this fix will be included in 0.3.2 and 0.4.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org