You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/11/06 13:13:01 UTC

[GitHub] [incubator-tvm] t-vi opened a new pull request #6865: Update search for bitcode files for rocm 3.9

t-vi opened a new pull request #6865:
URL: https://github.com/apache/incubator-tvm/pull/6865


   rocm 3.9 moved the bitcodes, we adapt to that.
   As this gives opaque error messages that are hard to debug (loading the module fails with could not initialize shared object but does not tell you about the missing symbols), we tighten the checks at this stage:
   - we become more strict with missing bitcodes,
   - we let the linker fail loudly for unresolved symbols.
   
   @masahi 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] t-vi commented on pull request #6865: Update search for bitcode files for rocm 3.9

Posted by GitBox <gi...@apache.org>.
t-vi commented on pull request #6865:
URL: https://github.com/apache/incubator-tvm/pull/6865#issuecomment-723227479


   I could use a hint regarding the CI failure.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] jroesch commented on pull request #6865: Update search for bitcode files for rocm 3.9

Posted by GitBox <gi...@apache.org>.
jroesch commented on pull request #6865:
URL: https://github.com/apache/incubator-tvm/pull/6865#issuecomment-723257007


   It looks like it could be flaky networking? networking code can be flaky even on localhost. I re-ran pipeline any thoughts @tqchen or @areusch 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] masahi commented on pull request #6865: Update search for bitcode files for rocm 3.9

Posted by GitBox <gi...@apache.org>.
masahi commented on pull request #6865:
URL: https://github.com/apache/incubator-tvm/pull/6865#issuecomment-723370898


   Thanks @t-vi 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] masahi merged pull request #6865: Update search for bitcode files for rocm 3.9

Posted by GitBox <gi...@apache.org>.
masahi merged pull request #6865:
URL: https://github.com/apache/incubator-tvm/pull/6865


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] t-vi commented on pull request #6865: Update search for bitcode files for rocm 3.9

Posted by GitBox <gi...@apache.org>.
t-vi commented on pull request #6865:
URL: https://github.com/apache/incubator-tvm/pull/6865#issuecomment-723426822


   Thank you @masahi and @jroesch and @areusch!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] areusch commented on pull request #6865: Update search for bitcode files for rocm 3.9

Posted by GitBox <gi...@apache.org>.
areusch commented on pull request #6865:
URL: https://github.com/apache/incubator-tvm/pull/6865#issuecomment-723262149


   @jroesch @t-vi best guess is a race condition in the test--it launches an rpc.Server, doesn't wait for it to start listening, then immediately connects. you can see in the captured teardown stdio that the "listening" message is printed, so i'd guess the test could use like a sleep(0.1) or better yet a retry on the connect call.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org