You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by "pan3793 (via GitHub)" <gi...@apache.org> on 2024/03/07 03:51:50 UTC
Re: [PR] [KYUUBI #6078] KSHC should handle the commit of the partitioned table as dynamic partition at write path [kyuubi]
pan3793 commented on code in PR #6082:
URL: https://github.com/apache/kyuubi/pull/6082#discussion_r1515465515
##########
extensions/spark/kyuubi-spark-connector-hive/src/main/scala/org/apache/kyuubi/spark/connector/hive/write/HiveWriteBuilder.scala:
##########
@@ -47,45 +41,22 @@ case class HiveWriteBuilder(
info,
hiveTableCatalog,
forceOverwrite,
- mergePartitionSpec(),
- ifPartitionNotExists)
+ dynamicPartitionSpec())
}
override def overwrite(filters: Array[Filter]): WriteBuilder = {
- filters match {
- case Array(AlwaysTrue) => // no partition, do nothing
- case _ => staticPartition = deduplicateFilters(filters)
- }
- overwriteDynamicPartitions()
+ forceOverwrite = true
Review Comment:
can we add an `requires` guard here?
##########
extensions/spark/kyuubi-spark-connector-hive/src/main/scala/org/apache/kyuubi/spark/connector/hive/write/HiveWriteBuilder.scala:
##########
@@ -47,45 +41,22 @@ case class HiveWriteBuilder(
info,
hiveTableCatalog,
forceOverwrite,
- mergePartitionSpec(),
- ifPartitionNotExists)
+ dynamicPartitionSpec())
}
override def overwrite(filters: Array[Filter]): WriteBuilder = {
- filters match {
- case Array(AlwaysTrue) => // no partition, do nothing
- case _ => staticPartition = deduplicateFilters(filters)
- }
- overwriteDynamicPartitions()
+ forceOverwrite = true
Review Comment:
can we add a `requires` guard here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org