You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2012/06/19 02:36:09 UTC
Review Request: Fix the race bug in ProcessManager::spawn in libprocess.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5409/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Vinod Kone.
Description
-------
The description of the bug can be found at:
https://issues.apache.org/jira/browse/MESOS-209
Diffs
-----
third_party/libprocess/src/process.cpp 13bb713
Diff: https://reviews.apache.org/r/5409/diff/
Testing
-------
Tested on Linux and Mac.
Make check.
Thanks,
Jie Yu
Re: Review Request: Fix the race bug in ProcessManager::spawn in libprocess.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5409/#review8377
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On June 19, 2012, 1:43 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5409/
> -----------------------------------------------------------
>
> (Updated June 19, 2012, 1:43 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> The description of the bug can be found at:
> https://issues.apache.org/jira/browse/MESOS-209
>
>
> Diffs
> -----
>
> third_party/libprocess/include/process/process.hpp 0894eb2
> third_party/libprocess/src/process.cpp 13bb713
>
> Diff: https://reviews.apache.org/r/5409/diff/
>
>
> Testing
> -------
>
> Tested on Linux and Mac.
>
> Make check.
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request: Fix the race bug in ProcessManager::spawn in libprocess.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5409/
-----------------------------------------------------------
(Updated June 19, 2012, 1:43 a.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
Fixed the bug in the PID<T> version (process.hpp).
Description
-------
The description of the bug can be found at:
https://issues.apache.org/jira/browse/MESOS-209
Diffs (updated)
-----
third_party/libprocess/include/process/process.hpp 0894eb2
third_party/libprocess/src/process.cpp 13bb713
Diff: https://reviews.apache.org/r/5409/diff/
Testing
-------
Tested on Linux and Mac.
Make check.
Thanks,
Jie Yu
Re: Review Request: Fix the race bug in ProcessManager::spawn in libprocess.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5409/#review8374
-----------------------------------------------------------
Just realized that this patch does not fully fix the bug. We also need to change:
template <typename T>
PID<T> spawn(T* t, bool manage = false)
(in libprocess/include/processes/process.hpp)
- Jie Yu
On June 19, 2012, 12:36 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5409/
> -----------------------------------------------------------
>
> (Updated June 19, 2012, 12:36 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> The description of the bug can be found at:
> https://issues.apache.org/jira/browse/MESOS-209
>
>
> Diffs
> -----
>
> third_party/libprocess/src/process.cpp 13bb713
>
> Diff: https://reviews.apache.org/r/5409/diff/
>
>
> Testing
> -------
>
> Tested on Linux and Mac.
>
> Make check.
>
>
> Thanks,
>
> Jie Yu
>
>