You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/11 07:09:14 UTC

[GitHub] [flink] pnowojski commented on pull request #11687: [FLINK-16536][network][checkpointing] Implement InputChannel state recovery for unaligned checkpoint

pnowojski commented on pull request #11687:
URL: https://github.com/apache/flink/pull/11687#issuecomment-626514600


   LGTM. One question:
   
   > In RecoveredInputChannel#getNextRecoveredStateBuffer, I move the future complete and related processes out of the synchronized (receivedBuffers) to avoid potential deadlock issue.
   
   Was this a precaution or a fix to a real deadlock? I don't see how in this case completing the future from within the critical section could deadlock, as the only thing attached it enqueuing something in the mailbox?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org