You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@uima.apache.org by sc...@apache.org on 2016/05/05 19:52:12 UTC

svn commit: r1742465 - /uima/uimaj/branches/experiment-v3-jcas/uimaj-core/src/main/java/org/apache/uima/util/impl/OptimizeStrings.java

Author: schor
Date: Thu May  5 19:52:12 2016
New Revision: 1742465

URL: http://svn.apache.org/viewvc?rev=1742465&view=rev
Log:
no Jira, refactor - change ArrayList<Integer> to IntVector, and use a better for loop

Modified:
    uima/uimaj/branches/experiment-v3-jcas/uimaj-core/src/main/java/org/apache/uima/util/impl/OptimizeStrings.java

Modified: uima/uimaj/branches/experiment-v3-jcas/uimaj-core/src/main/java/org/apache/uima/util/impl/OptimizeStrings.java
URL: http://svn.apache.org/viewvc/uima/uimaj/branches/experiment-v3-jcas/uimaj-core/src/main/java/org/apache/uima/util/impl/OptimizeStrings.java?rev=1742465&r1=1742464&r2=1742465&view=diff
==============================================================================
--- uima/uimaj/branches/experiment-v3-jcas/uimaj-core/src/main/java/org/apache/uima/util/impl/OptimizeStrings.java (original)
+++ uima/uimaj/branches/experiment-v3-jcas/uimaj-core/src/main/java/org/apache/uima/util/impl/OptimizeStrings.java Thu May  5 19:52:12 2016
@@ -27,6 +27,8 @@ import java.util.Map;
 import java.util.Set;
 import java.util.TreeSet;
 
+import org.apache.uima.internal.util.IntVector;
+
 /**
  * Share common underlying char[] among strings: Optimize sets of strings for
  * efficient storage
@@ -283,7 +285,7 @@ public class OptimizeStrings {
     String previous = "";
     int previousOffset = 0;
     offsets = new int[ssLength];
-    List<Integer> lastIndexInCommonStrings = new ArrayList<Integer>();
+    IntVector lastIndexInCommonStrings = new IntVector();
     List<String> commonStrings = new ArrayList<String>();
 
     for (int i = ssLength - 1; i >= 0; i--) {
@@ -311,10 +313,8 @@ public class OptimizeStrings {
     lastIndexInCommonStrings.add(0);   // the last index 
     
     // convert List<Integer> to int[]
-    lastIndexInCommonStringsA = new int[lastIndexInCommonStrings.size()];
-    for (int i = 0; i < lastIndexInCommonStrings.size(); i++) {
-      lastIndexInCommonStringsA[i] = lastIndexInCommonStrings.get(i);
-    }
+    lastIndexInCommonStrings.toArray();
+    lastIndexInCommonStringsA = lastIndexInCommonStrings.toArray();
     
     commonStringsA = commonStrings.toArray(new String[commonStrings.size()]);