[GitHub] lanking520 commented on a change in pull request #12489: [WIP][MXNET-918] Symbol Random api

[GitBox <gi...@apache.org>]

lanking520 commented on a change in pull request #12489: [WIP][MXNET-918] Symbol Random api
URL: https://github.com/apache/incubator-mxnet/pull/12489#discussion_r216536959
 
 

 ##########
 File path: scala-package/macros/src/main/scala/org/apache/mxnet/NDArrayMacro.scala
 ##########
 @@ -91,69 +114,74 @@ private[mxnet] object NDArrayMacro {
     val newNDArrayFunctions = {
       if (isContrib) ndarrayFunctions.filter(
         func => func.name.startsWith("_contrib_") || !func.name.startsWith("_"))
-      else ndarrayFunctions.filterNot(_.name.startsWith("_"))
+      else ndarrayFunctions.filterNot(f => f.name.startsWith("_") &&
+        !f.name.startsWith("sample_") && !f.name.startsWith("random_"))
 
 Review comment:
   You should not try to avoid `sample_` and `random_` from generation:
   [This](http://mxnet.incubator.apache.org/api/python/ndarray/ndarray.html#mxnet.ndarray.random_uniform) called by operator `random_uniform`.
   and [This](http://mxnet.incubator.apache.org/api/python/ndarray/random.html#mxnet.ndarray.random.uniform) called by operator `_random_uniform`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services