You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by GitBox <gi...@apache.org> on 2020/05/27 03:44:34 UTC
[GitHub] [guacamole-client] JordiRoman opened a new pull request #514: Docker enable cas auth
JordiRoman opened a new pull request #514:
URL: https://github.com/apache/guacamole-client/pull/514
This branch provides to Docker image use the guacamole-auth-cas (version 1.1.0).
Thank you very much.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] JordiRoman commented on pull request #514: GUACAMOLE-1082: Add guacamole-auth-cas to docker Script
Posted by GitBox <gi...@apache.org>.
JordiRoman commented on pull request #514:
URL: https://github.com/apache/guacamole-client/pull/514#issuecomment-664939742
HI @necouchman, sorry for disturb you.
I must do anything else or just have to wait
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] necouchman commented on a change in pull request #514: GUACAMOLE-1082: Add guacamole-auth-cas to docker Script
Posted by GitBox <gi...@apache.org>.
necouchman commented on a change in pull request #514:
URL: https://github.com/apache/guacamole-client/pull/514#discussion_r451490311
##########
File path: guacamole-docker/bin/start.sh
##########
@@ -567,6 +567,38 @@ END
ln -s /opt/guacamole/duo/guacamole-auth-*.jar "$GUACAMOLE_EXT"
}
+##
+## Adds properties to guacamole.properties witch configure the Cas
+## authentication service.
+##
+associate_cas() {
+ # Verify required parameters are present
+ if [ -z "$CAS_AUTHORIZATION_ENDPOINT" ] || \
+ [ -z "$CAS_REDIRECT_URI" ]
+ then
+ cat <<END
+FATAL: Missing required environment variables
+-----------------------------------------------------------------------------------
+If using the Cas authentication extension, you must provide each of the
Review comment:
You should be able to just make then changes and then do `git add` and `git commit --amend`, and then you can force push with a `git push -f`, which will update the pull request automatically.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] JordiRoman commented on pull request #514: GUACAMOLE-1082: guacamole-docker scripts with guacamole-auth-cas
Posted by GitBox <gi...@apache.org>.
JordiRoman commented on pull request #514:
URL: https://github.com/apache/guacamole-client/pull/514#issuecomment-633860872
Good morning.
I think I've fixed the problems. Sorry about the pull-request disaster.
I'm a rookie with a git, and I'm obviously doing things wrong.
Thank you very much for your patience.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] necouchman commented on pull request #514: GUACAMOLE-1082: Add guacamole-auth-cas to docker Script
Posted by GitBox <gi...@apache.org>.
necouchman commented on pull request #514:
URL: https://github.com/apache/guacamole-client/pull/514#issuecomment-655478087
Also, looks like there are some conflicts, now, that need to be resolve, so you should probably re-base on the current `apache:master`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] necouchman commented on a change in pull request #514: GUACAMOLE-1082: Add guacamole-auth-cas to docker Script
Posted by GitBox <gi...@apache.org>.
necouchman commented on a change in pull request #514:
URL: https://github.com/apache/guacamole-client/pull/514#discussion_r450511441
##########
File path: guacamole-docker/bin/start.sh
##########
@@ -567,6 +567,38 @@ END
ln -s /opt/guacamole/duo/guacamole-auth-*.jar "$GUACAMOLE_EXT"
}
+##
+## Adds properties to guacamole.properties witch configure the Cas
+## authentication service.
+##
+associate_cas() {
+ # Verify required parameters are present
+ if [ -z "$CAS_AUTHORIZATION_ENDPOINT" ] || \
+ [ -z "$CAS_REDIRECT_URI" ]
+ then
+ cat <<END
+FATAL: Missing required environment variables
+-----------------------------------------------------------------------------------
+If using the Cas authentication extension, you must provide each of the
Review comment:
Should probably be consistent about calling this the "CAS authentication extension."
##########
File path: guacamole-docker/bin/start.sh
##########
@@ -567,6 +567,38 @@ END
ln -s /opt/guacamole/duo/guacamole-auth-*.jar "$GUACAMOLE_EXT"
}
+##
+## Adds properties to guacamole.properties witch configure the Cas
Review comment:
Cas -> CAS
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] necouchman commented on pull request #514: Docker enable cas auth
Posted by GitBox <gi...@apache.org>.
necouchman commented on pull request #514:
URL: https://github.com/apache/guacamole-client/pull/514#issuecomment-633740963
@JordiRoman: Two big issues I see:
* The pull request title does not have the JIRA issue in it.
* You have a bunch of extra commits from your previous JIRA issue (Catalan support), you need to rebase this on top of the master branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] JordiRoman commented on a change in pull request #514: GUACAMOLE-1082: Add guacamole-auth-cas to docker Script
Posted by GitBox <gi...@apache.org>.
JordiRoman commented on a change in pull request #514:
URL: https://github.com/apache/guacamole-client/pull/514#discussion_r451335037
##########
File path: guacamole-docker/bin/start.sh
##########
@@ -567,6 +567,38 @@ END
ln -s /opt/guacamole/duo/guacamole-auth-*.jar "$GUACAMOLE_EXT"
}
+##
+## Adds properties to guacamole.properties witch configure the Cas
+## authentication service.
+##
+associate_cas() {
+ # Verify required parameters are present
+ if [ -z "$CAS_AUTHORIZATION_ENDPOINT" ] || \
+ [ -z "$CAS_REDIRECT_URI" ]
+ then
+ cat <<END
+FATAL: Missing required environment variables
+-----------------------------------------------------------------------------------
+If using the Cas authentication extension, you must provide each of the
Review comment:
yes, it's a typo error.
Can or should I add a new commit to the branch?
What should the commit description be [GUACAMOLE-1082: Add guacamole-auth-cas to docker Script - Cas 2 CAS typo ]?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] JordiRoman commented on a change in pull request #514: GUACAMOLE-1082: Add guacamole-auth-cas to docker Script
Posted by GitBox <gi...@apache.org>.
JordiRoman commented on a change in pull request #514:
URL: https://github.com/apache/guacamole-client/pull/514#discussion_r451337103
##########
File path: guacamole-docker/bin/start.sh
##########
@@ -567,6 +567,38 @@ END
ln -s /opt/guacamole/duo/guacamole-auth-*.jar "$GUACAMOLE_EXT"
}
+##
+## Adds properties to guacamole.properties witch configure the Cas
Review comment:
as above
I found another 'Cas' in my code, on line 739.
I'll change it too
Sorry
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] necouchman merged pull request #514: GUACAMOLE-1082: Add guacamole-auth-cas to docker Script
Posted by GitBox <gi...@apache.org>.
necouchman merged pull request #514:
URL: https://github.com/apache/guacamole-client/pull/514
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] JordiRoman commented on pull request #514: GUACAMOLE-1082: Add guacamole-auth-cas to docker Script
Posted by GitBox <gi...@apache.org>.
JordiRoman commented on pull request #514:
URL: https://github.com/apache/guacamole-client/pull/514#issuecomment-661723771
> Also, looks like there are some conflicts, now, that need to be resolve, so you should probably re-base on the current `apache:master`.
Hi, I re-base the code, solve the conflicts and push the branch.
Sorry
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] JordiRoman commented on pull request #514: GUACAMOLE-1082: Add guacamole-auth-cas to docker Script
Posted by GitBox <gi...@apache.org>.
JordiRoman commented on pull request #514:
URL: https://github.com/apache/guacamole-client/pull/514#issuecomment-661813932
> @JordiRoman - Unfortunately you now have a bunch of extra commits in this pull request.
Solved. Only 1 commit on branch.
Thankyou very much.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] necouchman commented on pull request #514: GUACAMOLE-1082: Add guacamole-auth-cas to docker Script
Posted by GitBox <gi...@apache.org>.
necouchman commented on pull request #514:
URL: https://github.com/apache/guacamole-client/pull/514#issuecomment-661773976
@JordiRoman - Unfortunately you now have a bunch of extra commits in this pull request.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org