You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2020/10/28 15:40:12 UTC
[GitHub] [orc] dongjoon-hyun opened a new pull request #557: ORC-677: Add a deprecated legacy constructor SargApplier back
dongjoon-hyun opened a new pull request #557:
URL: https://github.com/apache/orc/pull/557
### What changes were proposed in this pull request?
This PR aims to add a deprecated legacy constructor `SargApplier` back.
### Why are the changes needed?
ORC-27 removes this at Apache ORC 1.5.9 and 1.6.3 and this causes a compilation error at Apache Hive 3.1 branch (https://github.com/apache/hive/pull/1615).
- ORC-27: https://github.com/apache/orc/commit/949c7444ef98680026d9f2b93d7299b76cdfb030#diff-8678415090c906d11e0aa6241ba24643192cd66617c68d8deb0f7efe74dd2ba3L876-R883
### How was this patch tested?
Pass the CI with the newly added test case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun merged pull request #557: ORC-677: Add a deprecated legacy constructor SargApplier back
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun merged pull request #557:
URL: https://github.com/apache/orc/pull/557
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #557: ORC-677: Add a deprecated legacy constructor SargApplier back
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #557:
URL: https://github.com/apache/orc/pull/557#issuecomment-718282047
After https://github.com/apache/orc/pull/559 is merged, I'll rebase this PR. It seems that https://github.com/apache/orc/pull/559 recovers Travis CI's failure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #557: ORC-677. Add a deprecated legacy constructor SargApplier back
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #557:
URL: https://github.com/apache/orc/pull/557#issuecomment-717714242
Could you review this please, @omalley ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun closed pull request #557: ORC-677: Add a deprecated legacy constructor SargApplier back
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #557:
URL: https://github.com/apache/orc/pull/557
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun closed pull request #557: ORC-677: Add a deprecated legacy constructor SargApplier back
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #557:
URL: https://github.com/apache/orc/pull/557
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #557: ORC-677: Add a deprecated legacy constructor SargApplier back
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #557:
URL: https://github.com/apache/orc/pull/557#issuecomment-718266470
On the master branch, Travis CI passed.
- https://travis-ci.org/github/apache/orc/jobs/739663391
```
[INFO] --- findbugs-maven-plugin:3.0.5:check (analyze-compile) @ orc-core ---
[INFO] BugInstance size is 0
[INFO] Error size is 0
[INFO] No errors/warnings found
```
But, in this PR, the same code path failed like the following.
```
[INFO] --- findbugs-maven-plugin:3.0.5:check (analyze-compile) @ orc-core ---
[INFO] BugInstance size is 1
[INFO] Error size is 0
[INFO] Total bugs: 1
[INFO] Using .equals to compare two boolean[]'s, (equivalent to ==) in org.apache.orc.impl.TestRecordReaderImpl.testPositionalEvolutionAddColumnPPD() [org.apache.orc.impl.TestRecordReaderImpl] At TestRecordReaderImpl.java:[line 2301] EC_BAD_ARRAY_COMPARE
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Apache ORC ......................................... SUCCESS [ 4.086 s]
[INFO] ORC Shims .......................................... SUCCESS [ 9.718 s]
[INFO] ORC Core ........................................... FAILURE [02:17 min]
[INFO] ORC MapReduce ...................................... SKIPPED
[INFO] ORC Tools .......................................... SKIPPED
[INFO] ORC Examples ....................................... SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 02:32 min
[INFO] Finished at: 2020-10-28T22:46:33Z
[INFO] Final Memory: 52M/523M
[INFO] ------------------------------------------------------------------------
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #557: ORC-677: Add a deprecated legacy constructor SargApplier back
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #557:
URL: https://github.com/apache/orc/pull/557#issuecomment-718323788
Rebased to the master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on a change in pull request #557: ORC-677: Add a deprecated legacy constructor SargApplier back
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #557:
URL: https://github.com/apache/orc/pull/557#discussion_r513979311
##########
File path: java/core/src/test/org/apache/orc/impl/TestRecordReaderImpl.java
##########
@@ -2296,7 +2298,7 @@ public void testPositionalEvolutionAddColumnPPD() throws IOException {
boolean[] rows = applier.pickRowGroups(new ReaderImpl.StripeInformationImpl(stripe, 1, -1, null),
indexes, null, encodings, null, false);
- assertEquals(SargApplier.READ_ALL_RGS, rows); //cannot filter for new column, return all rows
+ assertEquals(true, Arrays.equals(SargApplier.READ_ALL_RGS, rows)); //cannot filter for new column, return all rows
Review comment:
This is irrelevant but satisfies the Travis CI's `EC_BAD_ARRAY_COMPARE` error detection. We can make this as a separate PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org