[GitHub] [spark] LuciferYang commented on a diff in pull request #38171: [SPARK-9213] [SQL] Improve regular expression performance (via joni)

["LuciferYang (via GitHub)" <gi...@apache.org>]

LuciferYang commented on code in PR #38171:
URL: https://github.com/apache/spark/pull/38171#discussion_r1166592390


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -4175,6 +4175,12 @@ object SQLConf {
     .checkValues(ErrorMessageFormat.values.map(_.toString))
     .createWithDefault(ErrorMessageFormat.PRETTY.toString)
 
+  val REGEX_ENGINE =

Review Comment:
   1. I suggest make the value as `Enumeration`, like 
   
   https://github.com/apache/spark/blob/4c938d62d791742b9f0c6a77b66fc06a90d7c0ad/core/src/main/scala/org/apache/spark/internal/config/History.scala#L241-L251
   
   and we should add `checkValues`.
   
   2. the config key should be `spark.sql.regex.engine`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org