You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/10/24 07:15:23 UTC
[GitHub] [incubator-nuttx] jerpelea opened a new pull request, #7410: boards: spresense: enable lte modem
jerpelea opened a new pull request, #7410:
URL: https://github.com/apache/incubator-nuttx/pull/7410
## Summary
Enable and configure ALT1250 LTE modem
## Impact
SPRESENSE LTE board
## Testing
spresense
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jerpelea commented on a diff in pull request #7410: boards: spresense: enable lte modem
Posted by GitBox <gi...@apache.org>.
jerpelea commented on code in PR #7410:
URL: https://github.com/apache/incubator-nuttx/pull/7410#discussion_r1003316912
##########
boards/arm/cxd56xx/spresense/include/cxd56_alt1250.h:
##########
@@ -46,47 +46,57 @@ extern "C"
* Public Function Prototypes
****************************************************************************/
-#if defined(CONFIG_MODEM_ALTMDM)
+#if defined(CONFIG_MODEM_ALT1250)
/****************************************************************************
- * Name: board_altmdm_initialize
+ * Name: board_alt1250_initialize
*
* Description:
* Initialize Altair modem
*
****************************************************************************/
-int board_altmdm_initialize(const char *devpath);
+int board_alt1250_initialize(FAR const char *devpath);
Review Comment:
thanks for catching it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] SPRESENSE commented on a diff in pull request #7410: boards: spresense: enable lte modem
Posted by GitBox <gi...@apache.org>.
SPRESENSE commented on code in PR #7410:
URL: https://github.com/apache/incubator-nuttx/pull/7410#discussion_r1003311458
##########
boards/arm/cxd56xx/spresense/include/cxd56_alt1250.h:
##########
@@ -46,47 +46,57 @@ extern "C"
* Public Function Prototypes
****************************************************************************/
-#if defined(CONFIG_MODEM_ALTMDM)
+#if defined(CONFIG_MODEM_ALT1250)
/****************************************************************************
- * Name: board_altmdm_initialize
+ * Name: board_alt1250_initialize
*
* Description:
* Initialize Altair modem
*
****************************************************************************/
-int board_altmdm_initialize(const char *devpath);
+int board_alt1250_initialize(FAR const char *devpath);
Review Comment:
```suggestion
int board_alt1250_initialize(const char *devpath);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7410: boards: spresense: enable lte modem
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #7410:
URL: https://github.com/apache/incubator-nuttx/pull/7410#discussion_r1003118050
##########
boards/arm/cxd56xx/common/src/cxd56_alt1250.c:
##########
@@ -75,36 +73,34 @@
# error "Select LTE SPI 4 or 5"
#endif
-#define WAIT_READY_TO_GPIO_INTERRUPT 300 /* micro seconds */
-
/****************************************************************************
* Private Function Prototypes
****************************************************************************/
-static void altmdm_poweron(void);
-static void altmdm_poweroff(void);
-static void altmdm_sready_irqattach(bool attach, xcpt_t handler);
-static void altmdm_sready_irqenable(bool enable);
-static bool altmdm_sready(void);
-static void altmdm_master_request(bool request);
-static void altmdm_wakeup(bool wakeup);
-static uint32_t altmdm_spi_maxfreq(void);
+static FAR struct spi_dev_s *alt1250_poweron(void);
Review Comment:
Remove FAR in this file
##########
boards/arm/cxd56xx/common/src/cxd56_alt1250.c:
##########
@@ -171,275 +167,262 @@ static void spi_pincontrol(int bus, bool on)
}
/****************************************************************************
- * Name: altmdm_poweron
+ * Name: set_spiparam
+ *
+ * Description:
+ * Setup the SPI parameters.
+ *
+ ****************************************************************************/
+
+static void set_spiparam(FAR struct spi_dev_s *spidev)
Review Comment:
```suggestion
static void set_spiparam(struct spi_dev_s *spidev)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #7410: boards: spresense: enable lte modem
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #7410:
URL: https://github.com/apache/incubator-nuttx/pull/7410
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org