[GitHub] [incubator-iotdb] jt2594838 commented on a change in pull request #1339: [IOTDB-723] add raft log delete mechanism

[GitBox <gi...@apache.org>]

jt2594838 commented on a change in pull request #1339:
URL: https://github.com/apache/incubator-iotdb/pull/1339#discussion_r437844557



##########
File path: cluster/src/main/java/org/apache/iotdb/cluster/log/manage/serializable/SyncLogDequeSerializer.java
##########
@@ -79,6 +85,24 @@
   // version controller
   private VersionController versionController;
 
+  private ScheduledExecutorService executorService;
+
+
+  /**
+   * the max number of committed logs to be saved
+   */
+  private int maxNumberLogs = 100;

Review comment:
       It would be better to put this into the configs.

##########
File path: cluster/src/main/java/org/apache/iotdb/cluster/log/manage/RaftLogManager.java
##########
@@ -50,6 +54,17 @@
   private long commitIndex;
   private LogApplier logApplier;
 
+  /**
+   * the max number of committed logs to be saved
+   */
+  private int maxNumberLogs = 100;

Review comment:
       It would be better to make this a config.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org