You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Steve Rowe (JIRA)" <ji...@apache.org> on 2017/05/23 23:51:04 UTC
[jira] [Updated] (SOLR-10438) schema-point.xml and TestPointFields
have suspicious assumptions about useDocValuesAsStored
[ https://issues.apache.org/jira/browse/SOLR-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steve Rowe updated SOLR-10438:
------------------------------
Attachment: SOLR-10438.patch
Patch, explicitly sets useDocValuesAsStored on all point fields/fieldtypes in {{schema-point.xml}}.
{{TestPointFields}} (the only consumer of {{schema-point.xml}}) passes with this change.
Committing shortly, once precommit passes.
> schema-point.xml and TestPointFields have suspicious assumptions about useDocValuesAsStored
> -------------------------------------------------------------------------------------------
>
> Key: SOLR-10438
> URL: https://issues.apache.org/jira/browse/SOLR-10438
> Project: Solr
> Issue Type: Sub-task
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Hoss Man
> Attachments: SOLR-10438.patch
>
>
> while working on SOLR-10425, i noticed that {{schema-point.xml}}, after defining many dynamicFields with {{docValues="true"}} (and no explicit mention of {{useDocValuesAsStored}}, then has a section with this comment...
> {code}
> <!-- return DV fields as -->
> <dynamicField name="*_p_i_dv_ns" type="pint" indexed="true" stored="false" docValues="true" useDocValuesAsStored="true"/>
> <dynamicField name="*_p_l_dv_ns" type="plong" indexed="true" stored="false" docValues="true" useDocValuesAsStored="true"/>
> ...
> {code}
> The problem with this is that the schema version=1.6, so useDocValuesAsStored="true" is already the implicit default for *all* of the other docValue field types defined in this schema -- making me skeptical of the efficacy of this test and any assumptions it has about wether {{useDocValuesAsStored}} is working properly (see also SOLR-10437)
> So we need to audit/clean-up this schema/test up to ensure that the effective value of {{useDocValuesAsStored}} is true if and only if the test code expects it to be true.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org