Re: [testing] Swing tests clean up

[Mark Hindess <ma...@googlemail.com>]

On 29 November 2006 at 9:31, Tim Ellison <t....@gmail.com> wrote:
> Chris Gray wrote:
> > On Wednesday 29 November 2006 00:03, Alexei Fedotov wrote:
> >> Nathan,
> >> You are doing a great job in Swing tests. Non-empty lines you've
> >> deleted repay triple cost of these empty lines. :-)
> >
> > There should be a sign above every programmer's desk: "how many
> > lines of code did you delete today?" :-)
> >
> > I'm serious - every line of code represents CPU cycles, footprint,
> > and worst of all potential bugs. Every time we make a real
> > improvement in Mika we end
>
> > up with less code than when we started.
>
> That's my mantra too.  It gives me great pleasure to remove
> unnecessary chunks and simplify code.

+1

> Keep up the good work Nathan.

+1.  (Thanks for your cleanup of the BasicSwingTestCase dependency.)

-Mark.

Re: [testing] Swing tests clean up

[Alexei Zakharov <al...@gmail.com>]

> the whitespace really helps signify separate "thoughts", IMO.

Exactly.

2006/11/29, Geir Magnusson Jr. <ge...@pobox.com>:
> But I do sympathize with the "don't remove all blank lines" camp - they
> don't actually cost any processor cycles, and they really can help
> readability.
>
> I know that is a subjective assessment, but I do find it hard to read
> through really white-space-free code - the whitespace really helps
> signify separate "thoughts", IMO.
>
> geir
>
> Mark Hindess wrote:
> > On 29 November 2006 at 9:31, Tim Ellison <t....@gmail.com> wrote:
> >> Chris Gray wrote:
> >>> On Wednesday 29 November 2006 00:03, Alexei Fedotov wrote:
> >>>> Nathan,
> >>>> You are doing a great job in Swing tests. Non-empty lines you've
> >>>> deleted repay triple cost of these empty lines. :-)
> >>> There should be a sign above every programmer's desk: "how many
> >>> lines of code did you delete today?" :-)
> >>>
> >>> I'm serious - every line of code represents CPU cycles, footprint,
> >>> and worst of all potential bugs. Every time we make a real
> >>> improvement in Mika we end
> >>> up with less code than when we started.
> >> That's my mantra too.  It gives me great pleasure to remove
> >> unnecessary chunks and simplify code.
> >
> > +1
> >
> >> Keep up the good work Nathan.
> >
> > +1.  (Thanks for your cleanup of the BasicSwingTestCase dependency.)

-- 
Alexei Zakharov,
Intel Enterprise Solutions Software Division

Re: [testing] Swing tests clean up

["Geir Magnusson Jr." <ge...@pobox.com>]

But I do sympathize with the "don't remove all blank lines" camp - they 
don't actually cost any processor cycles, and they really can help 
readability.

I know that is a subjective assessment, but I do find it hard to read 
through really white-space-free code - the whitespace really helps 
signify separate "thoughts", IMO.

geir

Mark Hindess wrote:
> On 29 November 2006 at 9:31, Tim Ellison <t....@gmail.com> wrote:
>> Chris Gray wrote:
>>> On Wednesday 29 November 2006 00:03, Alexei Fedotov wrote:
>>>> Nathan,
>>>> You are doing a great job in Swing tests. Non-empty lines you've
>>>> deleted repay triple cost of these empty lines. :-)
>>> There should be a sign above every programmer's desk: "how many
>>> lines of code did you delete today?" :-)
>>>
>>> I'm serious - every line of code represents CPU cycles, footprint,
>>> and worst of all potential bugs. Every time we make a real
>>> improvement in Mika we end
>>> up with less code than when we started.
>> That's my mantra too.  It gives me great pleasure to remove
>> unnecessary chunks and simplify code.
> 
> +1
> 
>> Keep up the good work Nathan.
> 
> +1.  (Thanks for your cleanup of the BasicSwingTestCase dependency.)
> 
> -Mark.
> 
>