[GitHub] [incubator-iceberg] waterlx commented on issue #474: Fix typo in the message for refreshing table metadata

[GitBox <gi...@apache.org>]

waterlx commented on issue #474: Fix typo in the message for refreshing table metadata
URL: https://github.com/apache/incubator-iceberg/pull/474#issuecomment-533471262
 
 
   Hi @rdblue , I am a little confused. Please help to clarify, thanks!
   Regarding the functions of https://github.com/apache/incubator-iceberg/blob/a509e43cf93d223a3925cbdcc5a0df4ac997b889/core/src/main/java/org/apache/iceberg/BaseMetastoreTableOperations.java#L134
   1. If newLocation is the source location where the metadata is being refreshed from, could you please share your idea about what `currentMetadataLocation` stands for?
   2. Does the message of "Refreshing table metadata from new version: newLocation" indicate that meta data is being refreshed from `newLocation`, not that the mata data is being refreshed from `currentMetadataLocation` to `newLocation` ? Before this message is issued, shown in `SHOW CREATE TABLE` of Hive, `metadata_location` in TBLPROPERTIES is `newLocation`, while `previous_metadata_location` is `currentMetadataLocation`. So does that message mean that the meta data is being refreshing from `newLocation` to somewhere else？

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org