svn commit: r1575447 - /subversion/trunk/subversion/libsvn_fs_fs/fs.h

[st...@apache.org]

Author: stefan2
Date: Fri Mar  7 23:07:04 2014
New Revision: 1575447

URL: http://svn.apache.org/r1575447
Log:
Follow-up to r1575428: Be consistent in how revnums are being
used in cache keys.

* subversion/libsvn_fs_fs/fs.h
  (window_cache_key_t): Widen the revision argument to 64 bit here as well.

Modified:
    subversion/trunk/subversion/libsvn_fs_fs/fs.h

Modified: subversion/trunk/subversion/libsvn_fs_fs/fs.h
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_fs_fs/fs.h?rev=1575447&r1=1575446&r2=1575447&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_fs_fs/fs.h (original)
+++ subversion/trunk/subversion/libsvn_fs_fs/fs.h Fri Mar  7 23:07:04 2014
@@ -267,18 +267,14 @@ typedef struct pair_cache_key_t
 
 /* Key type that identifies a txdelta window.
 
-   Note: Cache keys should be 16 bytes for best performance and there
-         should be no padding. */
+   Note: Cache keys should require no padding. */
 typedef struct window_cache_key_t
 {
-  /* Revision that contains the representation.
-     We limit this to 32 bit because it revision numbers are practically
-     limited to 32 bits by the RA layer, ATM, and we want to keep this
-     struct 16 bytes long. */
-  apr_uint32_t revision;
+  /* The object's revision.  Use the 64 data type to prevent padding. */
+  apr_int64_t revision;
 
-  /* Window number within that representation */
-  apr_int32_t chunk_index;
+  /* Window number within that representation. */
+  apr_int64_t chunk_index;
 
   /* Item index of the representation */
   apr_uint64_t item_index;