You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/04/28 03:42:04 UTC
[jira] [Commented] (TINKERPOP-1671) Default method for
RemoteConnection.submitAsync throws exception from submit on calling thread
instead of failing the future
[ https://issues.apache.org/jira/browse/TINKERPOP-1671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15988130#comment-15988130 ]
ASF GitHub Bot commented on TINKERPOP-1671:
-------------------------------------------
GitHub user tolbertam opened a pull request:
https://github.com/apache/tinkerpop/pull/605
TINKERPOP-1671 Propagate exception to Future instead of calling thread
For [TINKERPOP-1671](https://issues.apache.org/jira/browse/TINKERPOP-1671)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tolbertam/tinkerpop TINKERPOP-1671
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/605.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #605
----
commit 63dd3d083bc47eda06bc7b074a6594b04a9fc7a8
Author: Andrew Tolbert <an...@datastax.com>
Date: 2017-04-28T03:39:53Z
TINKERPOP-1671 Propagate exception to Future instead of calling thread
----
> Default method for RemoteConnection.submitAsync throws exception from submit on calling thread instead of failing the future
> ----------------------------------------------------------------------------------------------------------------------------
>
> Key: TINKERPOP-1671
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1671
> Project: TinkerPop
> Issue Type: Bug
> Components: process
> Affects Versions: 3.2.4
> Reporter: Andy Tolbert
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> If a {{RemoteConnection}} implementation does not provide override {{submitAsync}}, the default method is used which simply wraps {{submit}} in a future.
> One downside of this is that if an exception is thrown by {{submit}}, an exception is thrown on the calling thread instead of failing the future.
> Failing the future would be more preferable for consistencies sake, otherwise client code would need to consider that an exception could be thrown on the calling thread or that the future may fail.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)