[GitHub] [shiro] cstamas commented on pull request #308: [SHIRO-816] Hazelcast support does not support HZ v4

[GitBox <gi...@apache.org>]

cstamas commented on pull request #308:
URL: https://github.com/apache/shiro/pull/308#issuecomment-870304309


   @bmarwell as I see (in POM), the intent was to seamlessly work with both, HZ 3.x and HZ 4.x (at least that's what import range suggests). But alas, this never worked with both, as AFAIK the `IMap` package change was present in very first 4.0.x release as well. So, at first, it fixes it.
   Second, about "slow down", I am unaware of any code that would call `getCache` at some steady pace/rate. This calls AFAIK happens it majority of cases once in an application (correct me if I'm wrong here). So, while the `getCache` method is "slowed down", nothing else is slow, so unsure what you refer to "might slow down hz3".
   Finally, as I wrote in JIRA, consider this "hotfix", makes expectation come to reality in Shiro 1.x line. In 2.x line of Shiro I'd drop HZ3 support completely, and would compile (and run against) Hazelcast 4.x only. Drop the Hazelcast 3.x support in short.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org