[GitHub] [mina-sshd] alex-sherwin commented on a change in pull request #196: [SSHD-1164] - fixed parsing of sshd_config "Host" lines to collapse spaces

[GitBox <gi...@apache.org>]

alex-sherwin commented on a change in pull request #196:
URL: https://github.com/apache/mina-sshd/pull/196#discussion_r632982475



##########
File path: sshd-common/src/main/java/org/apache/sshd/client/config/hosts/HostConfigEntry.java
##########
@@ -1087,6 +1087,7 @@ public static void writeHostConfigEntries(
      */
     public static List<String> parseConfigValue(String value) {
         String s = GenericUtils.replaceWhitespaceAndTrim(value);
+        s = GenericUtils.collapseSpaces(s);

Review comment:
       I see, this is re-used for various types of config file values.  In the case I'm trying to fix it's limited to `Host` only, but I suppose the problem would be generic to any kind of config that supports multiple values (not sure how many of those exist)
   
   I could change the PR to work inside the `if (HOST_CONFIG_PROP.equalsIgnoreCase(key)) {` block, but it would work differently, at this point it would have to filter out empty string values from the list that was parsed incorrectly




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org