You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/04/13 12:49:41 UTC
[jira] [Commented] (CB-12266) InappBrowser: Browser: loadstop
event.url is not a string
[ https://issues.apache.org/jira/browse/CB-12266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15967538#comment-15967538 ]
ASF GitHub Bot commented on CB-12266:
-------------------------------------
GitHub user matrosov-nikita opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/217
CB-12266 browser: Fix type for InAppBrowserEvent url in docs
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
browser
### What does this PR do?
fix doc's description for URL
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/matrosov-nikita/cordova-plugin-inappbrowser fix-docs
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/217.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #217
----
commit 6a93e34d459cd13ce74c9b01b595e242399ece16
Author: Nikita Matrosov <v-...@microsoft.com>
Date: 2017-04-06T10:33:30Z
CB-12266 browser: Fix type for InAppBrowserEvent url in docs
----
> InappBrowser: Browser: loadstop event.url is not a string
> ---------------------------------------------------------
>
> Key: CB-12266
> URL: https://issues.apache.org/jira/browse/CB-12266
> Project: Apache Cordova
> Issue Type: Bug
> Components: Browser, Plugin InAppBrowser
> Affects Versions: 3.5.0
> Environment: All browsers (Chrome, Firefox and IE tested)
> Reporter: Pieter-Jan Dewitte
> Priority: Minor
>
> In the browser, the url attribute of the loadstop event (InAppBrowserEvent) is not a string as documented, but a Location object. The url is stored in event.href.
> Steps to reproduce:
> {quote}
> $ cordova create eventstop_url
> $ cd eventstop_url
> $ cordova plugin add cordova-plugin-inappbrowser
> {quote}
> Run the following code after device ready:
> {code:javascript}
> // https://ssl.gstatic.com as an example because it is allowed by the default CSP
> var ref = cordova.InAppBrowser.open('https://ssl.gstatic.com', '_blank');
> ref.addEventListener('loadstop', function (event) {
> console.log("loadstop event:", event);
> });
> {code}
> {quote}
> $ cordova serve
> {quote}
> The console output is:
> {quote}
> loadstop event: Object \{type: "loadstop", url: Location\}
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org