You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/04/18 20:53:52 UTC
[GitHub] [tvm] driazati opened a new pull request, #11045: [docs] Add lightweight docs image
driazati opened a new pull request, #11045:
URL: https://github.com/apache/tvm/pull/11045
This image includes everything necessary to build the docs without any tutorials and is just about 1.5 GB which is significantly less than the CPU/GPU images.
TODO:
* PR to tlcpack/tlcpack to build this image
Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @ them in the pull request thread.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] github-actions[bot] commented on pull request #11045: [docs] Add lightweight docs image
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #11045:
URL: https://github.com/apache/tvm/pull/11045#issuecomment-1118002935
It has been a while since this PR was updated, @areusch please leave a review or address the outstanding comments. @driazati if this PR is still a work in progress, please [convert it to a draft](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/changing-the-stage-of-a-pull-request#converting-a-pull-request-to-a-draft) until it is ready for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on pull request #11045: [docs] Add lightweight docs image
Posted by GitBox <gi...@apache.org>.
areusch commented on PR #11045:
URL: https://github.com/apache/tvm/pull/11045#issuecomment-1124090558
@driazati want to fix the CI issue? i think we can merge once it's green
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on a diff in pull request #11045: [docs] Add lightweight docs image
Posted by GitBox <gi...@apache.org>.
areusch commented on code in PR #11045:
URL: https://github.com/apache/tvm/pull/11045#discussion_r855638338
##########
tests/scripts/ci.py:
##########
@@ -239,20 +231,20 @@ def docs(
skip_build -- skip build and setup scripts
interactive -- start a shell after running build / test scripts
"""
- config = "./tests/scripts/task_config_build_gpu.sh"
build_dir = get_build_dir("gpu")
if cpu and full:
Review Comment:
but doesn't cpu flag now imply ci_docs, not ci_cpu? just thinking it's named a bit weird
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on a diff in pull request #11045: [docs] Add lightweight docs image
Posted by GitBox <gi...@apache.org>.
areusch commented on code in PR #11045:
URL: https://github.com/apache/tvm/pull/11045#discussion_r855488162
##########
docker/build.sh:
##########
@@ -99,6 +99,11 @@ if [[ "$1" == "--cache-from" ]]; then
shift 1
fi
+if [[ "$1" == "--cache" ]]; then
Review Comment:
can you add to the docs above?
##########
tests/scripts/ci.py:
##########
@@ -239,20 +231,20 @@ def docs(
skip_build -- skip build and setup scripts
interactive -- start a shell after running build / test scripts
"""
- config = "./tests/scripts/task_config_build_gpu.sh"
build_dir = get_build_dir("gpu")
if cpu and full:
Review Comment:
should we change the cpu flag name here too? seems like it's more like tutorials or not
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] driazati commented on a diff in pull request #11045: [docs] Add lightweight docs image
Posted by GitBox <gi...@apache.org>.
driazati commented on code in PR #11045:
URL: https://github.com/apache/tvm/pull/11045#discussion_r855576983
##########
tests/scripts/ci.py:
##########
@@ -239,20 +231,20 @@ def docs(
skip_build -- skip build and setup scripts
interactive -- start a shell after running build / test scripts
"""
- config = "./tests/scripts/task_config_build_gpu.sh"
build_dir = get_build_dir("gpu")
if cpu and full:
Review Comment:
not necessarily since tutorials don’t always require the GPU, though it’s probably usually used they way you mention, i’d prefer keeping it closer to what’s actually going on so it’s more clear how the tool works
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] driazati commented on a diff in pull request #11045: [docs] Add lightweight docs image
Posted by GitBox <gi...@apache.org>.
driazati commented on code in PR #11045:
URL: https://github.com/apache/tvm/pull/11045#discussion_r856496871
##########
tests/scripts/ci.py:
##########
@@ -239,20 +231,20 @@ def docs(
skip_build -- skip build and setup scripts
interactive -- start a shell after running build / test scripts
"""
- config = "./tests/scripts/task_config_build_gpu.sh"
build_dir = get_build_dir("gpu")
if cpu and full:
Review Comment:
resolved offline, removed the `--cpu` flag so the user doesnt need to directly state the image and its implied from whether the tutorials are built or not
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch merged pull request #11045: [docs] Add lightweight docs image
Posted by GitBox <gi...@apache.org>.
areusch merged PR #11045:
URL: https://github.com/apache/tvm/pull/11045
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org