[jira] [Commented] (LUCENE-4171) Performance improvements to Packed64

["Adrien Grand (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-4171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13402947#comment-13402947 ] 

Adrien Grand commented on LUCENE-4171:
--------------------------------------

Patch looks very good, all core tests pass on my computer too. Maybe still two minor things to fix before commit:
 - you shouldn't override {{getArray}}. This method must return a non-null array only when the number of bits per value matches the backing array type (some components use it to directly work with an array instead of a PackedInts.Reader).
 - could you use lower camelCase for instance variables (MASK_LEFT, MASK_RIGHT and BPV_MINUS_BLOCK_SIZE)?
                
> Performance improvements to Packed64
> ------------------------------------
>
>                 Key: LUCENE-4171
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4171
>             Project: Lucene - Java
>          Issue Type: Sub-task
>          Components: core/other
>    Affects Versions: 4.0, 5.0
>         Environment: Tested with 4 different Intel machines
>            Reporter: Toke Eskildsen
>            Priority: Minor
>              Labels: performance
>         Attachments: LUCENE-4171.patch
>
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> Based on the performance measurements of PackedInts.Mutable's in LUCENE-4062, a new version of Packed64 has been created that is consistently faster than the old Packed64 for both get and set.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org